Code review comment for lp:~nik90/ubuntu/precise/vlc/keywords

Didier Roche (didrocks) wrote :

Hey Nekhelesh,
thanks for your contribution to ubuntu and for this merge requests :)

Some notes about it:
- we normally comment the changes in the debian/changelog file. For that, we are using debchange -i and write something like:
- move the .desktop file change into something the patch system of the package can deal with
- we are in sync with debian for that, and don't really want to be not in sync anymore for only that is something which might interest you in this regard. This is the end result:

Also, we try to forward the change to Upstream directly. I opened a bug in the vlc tracker with this patch attached. We would really appreciate if you can do that yourself next time and stating it on the merge request).

Thanks again for your contribution there! That's really appreciated :)

Also, you are repeating some words that are in the application name or the comment that are used for searching. I removed them.

I'm disapproving this branch, but look at upstream bug tracker

review: Disapprove

« Back to merge proposal