Merge lp:~nik90/ubuntu/precise/transmission/add_quicklist_updated into lp:ubuntu/precise/transmission

Proposed by Nekhelesh Ramananthan on 2012-02-29
Status: Merged
Merge reported by: Didier Roche
Merged at revision: not available
Proposed branch: lp:~nik90/ubuntu/precise/transmission/add_quicklist_updated
Merge into: lp:ubuntu/precise/transmission
Diff against target: 37 lines (+22/-0)
2 files modified
gtk/transmission-gtk.desktop.in (+11/-0)
qt/transmission-qt.desktop (+11/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu/precise/transmission/add_quicklist_updated
Reviewer Review Type Date Requested Status
Didier Roche Approve on 2012-02-29
Ubuntu branches 2012-02-29 Pending
Review via email: mp+95084@code.launchpad.net

Description of the change

Transmission quicklist support added with latest desktop specifications like title and Actions.

To post a comment you must log in.
Nekhelesh Ramananthan (nik90) wrote :

@Michael Hall, I had to create a new branch since I could not upload to my old branch. Hence this new merge proposal as well.

Didier Roche (didrocks) wrote :

Hey Nekhelesh,
thanks for your contribution to ubuntu and for this merge requests :)

Some notes about it:
- we normally comment the changes in the debian/changelog file. For that, we are using debchange -i and write something like:
- move the .desktop file change into something the patch system of the package can deal with

http://developer.ubuntu.com/packaging/html/udd-patchsys.html#edit-patch is something which might interest you in this regard. This is the end result: http://paste.ubuntu.com/855106/

Also, we try to forward the change to Upstream directly. I opened a bug in the GNOME bugzilla tracker with this patch attached. We would really appreciate if you can do that yourself next time and stating it on the merge request).

Thanks again for your contribution there! That's really appreciated :)

Marking manually as merged as I needed to put it in a patch with another branch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk/transmission-gtk.desktop.in'
2--- gtk/transmission-gtk.desktop.in 2011-07-19 10:35:40 +0000
3+++ gtk/transmission-gtk.desktop.in 2012-02-29 00:55:20 +0000
4@@ -12,3 +12,14 @@
5 Categories=Network;FileTransfer;P2P;GTK;
6 X-Ubuntu-Gettext-Domain=transmission
7 X-AppInstall-Keywords=torrent
8+Actions=Pause;Minimize;
9+
10+[Desktop Action Pause]
11+Name=Start Transmission with all Torrents Paused
12+Exec=transmission-gtk --paused
13+OnlyShowIn=Unity
14+
15+[Desktop Action Minimize]
16+Name=Start Transmission Minimized
17+Exec=transmission-gtk --minimized
18+OnlyShowIn=Unity
19
20=== modified file 'qt/transmission-qt.desktop'
21--- qt/transmission-qt.desktop 2011-01-28 21:45:01 +0000
22+++ qt/transmission-qt.desktop 2012-02-29 00:55:20 +0000
23@@ -9,3 +9,14 @@
24 MimeType=application/x-bittorrent;
25 Categories=Network;FileTransfer;P2P;Qt;
26 X-AppInstall-Keywords=torrent
27+Actions=Pause;Minimize;
28+
29+[Desktop Action Pause]
30+Name=Start Transmission with all Torrents Paused
31+Exec=transmission-gtk --paused
32+OnlyShowIn=Unity
33+
34+[Desktop Action Minimize]
35+Name=Start Transmission Minimized
36+Exec=transmission-gtk --minimized
37+OnlyShowIn=Unity

Subscribers

People subscribed via source and target branches