Ubuntu

Merge lp:~nik90/ubuntu/precise/totem/add_quicklist into lp:ubuntu/precise/totem

Proposed by Nekhelesh Ramananthan on 2012-02-22
Status: Merged
Merge reported by: Stéphane Graber
Merged at revision: not available
Proposed branch: lp:~nik90/ubuntu/precise/totem/add_quicklist
Merge into: lp:ubuntu/precise/totem
Diff against target: 33 lines (+26/-0) 1 file modified
To merge this branch: bzr merge lp:~nik90/ubuntu/precise/totem/add_quicklist
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing on 2012-03-05
Michael Hall (community) Needs Fixing on 2012-02-28
Ubuntu branches 2012-02-22 Pending
Review via email: mp+94170@code.launchpad.net

Description of the Change

I have added quicklist for totem which provides options for play,next,previous,mute and fullscreen.

To post a comment you must log in.
Michael Hall (mhall119) wrote :

Thanks so much for your submission!

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please update this merge proposal with these changes so they can be included in the upcoming release of Ubuntu. Please also make sure you submit them to the upstream developers so they can be included there in future versions.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

review: Needs Fixing
Nekhelesh Ramananthan (nik90) wrote :

I have updated the quicklist with the above mentioned changes which were required. Please review the latest code again. Thank you.

Nekhelesh Ramananthan (nik90) wrote :

I have reported this bug upstream with the patch.

Sebastien Bacher (seb128) wrote :

Thank you for your work, you need to prefix the Name with a "_" so they are translatable though

Could you also do a different patch for the keywords and the lists?

Setting to "Work in progress" please set back to "Needs review" when you update so it shows again on the sponsoring list

review: Needs Fixing
Stéphane Graber (stgraber) wrote :

Manually merged into lp:~ubuntu-desktop/totem/ubuntu as a Debian patch in debian/patches and uploaded.

Preview Diff

1=== modified file 'data/totem.desktop.in.in.in'
2--- data/totem.desktop.in.in.in 2009-05-21 20:20:37 +0000
3+++ data/totem.desktop.in.in.in 2012-03-05 16:43:47 +0000
4@@ -14,3 +14,29 @@
5 X-GNOME-Bugzilla-OtherBinaries=totem-video-indexer;totem-video-thumbnailer;totem-audio-preview;
6 X-GNOME-Bugzilla-ExtraInfoScript=@FULL_LIBEXECDIR@/totem/totem-bugreport.py
7 StartupNotify=true
8+Actions=Play;Next;Previous;Mute;Fullscreen;
9+
10+[Desktop Action Play]
11+_Name=Play/Pause
12+Exec=totem --play-pause
13+OnlyShowIn=Unity;
14+
15+[Desktop Action Next]
16+_Name=Next
17+Exec=totem --next
18+OnlyShowIn=Unity;
19+
20+[Desktop Action Previous]
21+_Name=Previous
22+Exec=totem --previous
23+OnlyShowIn=Unity;
24+
25+[Desktop Action Mute]
26+_Name=Mute
27+Exec=totem --mute
28+OnlyShowIn=Unity;
29+
30+[Desktop Action Fullscreen]
31+_Name=Fullscreen
32+Exec=totem --fullscreen
33+OnlyShowIn=Unity;

Subscribers

People subscribed via source and target branches