Code review comment for lp:~nik90/ubuntu/precise/remmina/add_quicklist

Michael Hall (mhall119) wrote :

Thanks so much for your submission!

Unfortunately your submission is for a package that can only be translated by the upstream developers, so you will need to send your changes to them first. If they are accepted by the upstream project, they will then be included in the next release of Ubuntu.

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please make these changes and submit them to the upstream projects so they can be included in future versions of project and future releases of Ubuntu.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

review: Needs Fixing

« Back to merge proposal