Merge lp:~nik90/ubuntu/precise/evince/keywords into lp:ubuntu/precise/evince

Proposed by Nekhelesh Ramananthan
Status: Merged
Merge reported by: Didier Roche-Tolomelli
Merged at revision: not available
Proposed branch: lp:~nik90/ubuntu/precise/evince/keywords
Merge into: lp:ubuntu/precise/evince
Diff against target: 8 lines (+1/-0)
1 file modified
data/evince.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu/precise/evince/keywords
Reviewer Review Type Date Requested Status
Jeremy Bícha Disapprove
Didier Roche-Tolomelli Approve
Ubuntu branches Pending
Review via email: mp+95087@code.launchpad.net

Description of the change

Updated .desktop file to include keyword specification as mentioned in XDG.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Nekhelesh,
thanks for your contribution to ubuntu and for this merge requests :)

Some notes about it:
- we normally comment the changes in the debian/changelog file. For that, we are using debchange -i and write something like:
- move the .desktop file change into something the patch system of the package can deal with
- the correct branch to target is the one in debian/control: Vcs-Bzr: (which is in that case lp:~ubuntu-desktop/…)

http://developer.ubuntu.com/packaging/html/udd-patchsys.html#edit-patch is something which might interest you in this regard. This is the end result: http://paste.ubuntu.com/855106/

Also, we try to forward the change to Upstream directly. I open a bug in the GNOME bugzilla tracker with this patch attached. We would really appreciate if you can do that yourself next time and stating it on the merge request).

Thanks again for your contribution there! That's really appreciated :)

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

FYI, I set the proposal as "merged" but I in fact merged the ubuntu-desktop branch :)

Revision history for this message
Jeremy Bícha (jbicha) wrote :

This is wrong. "Document Viewer" is already in the .desktop so it's already searchable.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/evince.desktop.in.in'
2--- data/evince.desktop.in.in 2011-11-24 18:38:42 +0000
3+++ data/evince.desktop.in.in 2012-02-29 02:01:18 +0000
4@@ -14,3 +14,4 @@
5 X-GNOME-Bugzilla-Version=@VERSION@
6 Categories=GNOME;GTK;Graphics;VectorGraphics;Viewer;
7 MimeType=@EVINCE_MIME_TYPES@
8+_Keywords=Document;Viewer;

Subscribers

People subscribed via source and target branches