Merge lp:~nik90/ubuntu-weather-app/added-desktop-file into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: David Planella
Approved revision: 235
Merged at revision: 233
Proposed branch: lp:~nik90/ubuntu-weather-app/added-desktop-file
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 14 lines (+10/-0)
1 file modified
ubuntu-weather-app.desktop (+10/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-weather-app/added-desktop-file
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+216062@code.launchpad.net

Commit message

Added desktop file to allow for testing on device using Qtcreator

Description of the change

Since the CMAKE transition, it is not possible to run the weather app on device using Qtcreator due to a missing desktop file. This has been added until an official fix is provided for by the qtcreator ubuntu plugins. This method is also used by the clock app.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

10 +Exec=qmlscene /usr/share/ubuntu-weather-app/ubuntu-weather-app.qml

To run on the source tree, this should probably be:

Exec=qmlscene ubuntu-weather-app.qml

review: Needs Fixing
Revision history for this message
David Planella (dpm) wrote :

LGTM now, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

While we're at it, and since this needs reapproval, could you modify the Exec line again?

10 +Exec=qmlscene ubuntu-weather-app.qml

To be:

Exec=qmlscene -qt5 ubuntu-weather-app.qml

review: Needs Fixing
235. By Nekhelesh Ramananthan

Added qt5 to exec line

Revision history for this message
David Planella (dpm) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'ubuntu-weather-app.desktop'
2--- ubuntu-weather-app.desktop 1970-01-01 00:00:00 +0000
3+++ ubuntu-weather-app.desktop 2014-04-16 14:42:19 +0000
4@@ -0,0 +1,10 @@
5+[Desktop Entry]
6+Encoding=UTF-8
7+Version=1.0
8+Type=Application
9+Terminal=false
10+Exec=qmlscene -qt5 ubuntu-weather-app.qml
11+Icon=weather64.png
12+Name=Weather
13+X-Ubuntu-Touch=true
14+X-Ubuntu-StageHint=SideStage

Subscribers

People subscribed via source and target branches