Merge lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links into lp:ubuntu-weather-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Martin Borho
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links
Merge into: lp:ubuntu-weather-app
Diff against target: 126 lines (+24/-25)
3 files modified
app/ui/CMakeLists.txt (+1/-1)
app/ui/SettingsPage.qml (+3/-4)
po/com.ubuntu.weather.pot (+20/-20)
To merge this branch: bzr merge lp:~nik90/ubuntu-weather-app/0-fix-broken-settings-links
Reviewer Review Type Date Requested Status
Martin Borho Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+252112@code.launchpad.net

Commit message

Fxied the broken settings page links and also renamed Settings folder to settings to maintain consistency.

Description of the change

This MP fixes the broken settings page links and also renames Settings folder to settings to maintain consistency.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Borho (martin-borho) wrote :

lgtm, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/CMakeLists.txt'
2--- app/ui/CMakeLists.txt 2015-02-09 19:49:06 +0000
3+++ app/ui/CMakeLists.txt 2015-03-06 13:42:03 +0000
4@@ -1,4 +1,4 @@
5-add_subdirectory(Settings)
6+add_subdirectory(settings)
7
8 file(GLOB UI_QML_JS_FILES *.qml *.js)
9
10
11=== modified file 'app/ui/SettingsPage.qml'
12--- app/ui/SettingsPage.qml 2015-02-09 19:49:06 +0000
13+++ app/ui/SettingsPage.qml 2015-03-06 13:42:03 +0000
14@@ -20,7 +20,6 @@
15 import Ubuntu.Components 1.1
16 import Ubuntu.Components.ListItems 0.1 as ListItem
17
18-
19 Page {
20 title: i18n.tr("Settings")
21
22@@ -41,21 +40,21 @@
23 progression: true
24 text: i18n.tr("Units")
25
26- onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/UnitsPage.qml"))
27+ onClicked: mainPageStack.push(Qt.resolvedUrl("settings/UnitsPage.qml"))
28 }
29
30 ListItem.SingleValue {
31 progression: true
32 text: i18n.tr("Data Provider")
33
34- onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/DataProviderPage.qml"))
35+ onClicked: mainPageStack.push(Qt.resolvedUrl("settings/DataProviderPage.qml"))
36 }
37
38 ListItem.SingleValue {
39 progression: true
40 text: i18n.tr("Refresh Interval")
41
42- onClicked: mainPageStack.push(Qt.resolvedUrl("Settings/RefreshIntervalPage.qml"))
43+ onClicked: mainPageStack.push(Qt.resolvedUrl("settings/RefreshIntervalPage.qml"))
44 }
45 }
46 }
47
48=== renamed directory 'app/ui/Settings' => 'app/ui/settings'
49=== modified file 'po/com.ubuntu.weather.pot'
50--- po/com.ubuntu.weather.pot 2015-03-03 18:46:47 +0000
51+++ po/com.ubuntu.weather.pot 2015-03-06 13:42:03 +0000
52@@ -8,7 +8,7 @@
53 msgstr ""
54 "Project-Id-Version: ubuntu-weather-app\n"
55 "Report-Msgid-Bugs-To: \n"
56-"POT-Creation-Date: 2015-03-03 18:45+0000\n"
57+"POT-Creation-Date: 2015-03-06 14:23+0100\n"
58 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
59 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
60 "Language-Team: LANGUAGE <LL@li.org>\n"
61@@ -65,46 +65,46 @@
62 msgid "Locations"
63 msgstr ""
64
65-#: ../app/ui/Settings/DataProviderPage.qml:25 ../app/ui/SettingsPage.qml:49
66+#: ../app/ui/SettingsPage.qml:25
67+msgid "Settings"
68+msgstr ""
69+
70+#: ../app/ui/SettingsPage.qml:42 ../app/ui/settings/UnitsPage.qml:25
71+msgid "Units"
72+msgstr ""
73+
74+#: ../app/ui/SettingsPage.qml:49 ../app/ui/settings/DataProviderPage.qml:25
75 msgid "Data Provider"
76 msgstr ""
77
78-#: ../app/ui/Settings/DataProviderPage.qml:44
79+#: ../app/ui/SettingsPage.qml:56 ../app/ui/settings/RefreshIntervalPage.qml:25
80+msgid "Refresh Interval"
81+msgstr ""
82+
83+#: ../app/ui/settings/DataProviderPage.qml:44
84 msgid "Provider"
85 msgstr ""
86
87-#: ../app/ui/Settings/RefreshIntervalPage.qml:25 ../app/ui/SettingsPage.qml:56
88-msgid "Refresh Interval"
89-msgstr ""
90-
91-#: ../app/ui/Settings/RefreshIntervalPage.qml:42
92+#: ../app/ui/settings/RefreshIntervalPage.qml:42
93 msgid "minutes"
94 msgstr ""
95
96-#: ../app/ui/Settings/RefreshIntervalPage.qml:47
97+#: ../app/ui/settings/RefreshIntervalPage.qml:47
98 msgid "Interval"
99 msgstr ""
100
101-#: ../app/ui/Settings/UnitsPage.qml:25 ../app/ui/SettingsPage.qml:42
102-msgid "Units"
103-msgstr ""
104-
105-#: ../app/ui/Settings/UnitsPage.qml:44
106+#: ../app/ui/settings/UnitsPage.qml:44
107 msgid "Temperature"
108 msgstr ""
109
110-#: ../app/ui/Settings/UnitsPage.qml:56
111+#: ../app/ui/settings/UnitsPage.qml:56
112 msgid "Precipitation"
113 msgstr ""
114
115-#: ../app/ui/Settings/UnitsPage.qml:67
116+#: ../app/ui/settings/UnitsPage.qml:67
117 msgid "Wind Speed"
118 msgstr ""
119
120-#: ../app/ui/SettingsPage.qml:25
121-msgid "Settings"
122-msgstr ""
123-
124 #: ubuntu-weather-app.desktop.in.in.h:1
125 msgid "Weather"
126 msgstr ""

Subscribers

People subscribed via source and target branches