Merge lp:~nik90/ubuntu-ui-toolkit/panel-animation-speed into lp:ubuntu-ui-toolkit

Proposed by Nekhelesh Ramananthan on 2014-06-15
Status: Superseded
Proposed branch: lp:~nik90/ubuntu-ui-toolkit/panel-animation-speed
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 37 lines (+8/-1)
2 files modified
components.api (+1/-0)
modules/Ubuntu/Components/Panel.qml (+7/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-ui-toolkit/panel-animation-speed
Reviewer Review Type Date Requested Status
Ubuntu SDK team 2014-06-15 Pending
Review via email: mp+223185@code.launchpad.net

Commit message

Adds a property to set the panel swipe animation speed.

Description of the change

Adds a property to set the panel swipe animation speed. By default it is set to UbuntuAnimation.FastDuration to not break compatibility with existing applications which use the panel.

To post a comment you must log in.
1033. By Nekhelesh Ramananthan on 2014-06-16

Changed property name to animationDuration

1034. By Nekhelesh Ramananthan on 2014-06-16

Move the new property over to the 1.1 API instead of 1.0

1035. By Nekhelesh Ramananthan on 2014-06-16

Added 1.1 change in the qmldir as well

Unmerged revisions

1035. By Nekhelesh Ramananthan on 2014-06-16

Added 1.1 change in the qmldir as well

1034. By Nekhelesh Ramananthan on 2014-06-16

Move the new property over to the 1.1 API instead of 1.0

1033. By Nekhelesh Ramananthan on 2014-06-16

Changed property name to animationDuration

1032. By Nekhelesh Ramananthan on 2014-06-15

Added property to set the speed of the panel swipe animation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components.api'
2--- components.api 2014-05-28 18:08:33 +0000
3+++ components.api 2014-06-15 21:47:41 +0000
4@@ -256,6 +256,7 @@
5 Item
6 default property list<Object> contents
7 property int align
8+ property int animateDuration
9 property bool opened
10 function open()
11 function close()
12
13=== modified file 'modules/Ubuntu/Components/Panel.qml'
14--- modules/Ubuntu/Components/Panel.qml 2014-04-25 12:53:58 +0000
15+++ modules/Ubuntu/Components/Panel.qml 2014-06-15 21:47:41 +0000
16@@ -171,6 +171,12 @@
17 */
18 property int align: Qt.AlignBottom
19
20+ /* !
21+ The property defines the swipe in/out speed of the panel.
22+ The default value is \b UbuntuAnimation.FastDuration.
23+ */
24+ property int animateDuration: Toolkit.UbuntuAnimation.FastDuration
25+
26 /*!
27 When opened, the panel is visible, otherwise it is hidden.
28 Use edge swipes to open/close the panel.
29@@ -402,7 +408,7 @@
30 The duration in milliseconds of sliding in or out transitions when opening, closing, and showing the hint.
31 Default value: 250
32 */
33- property real transitionDuration: panel.animate ? Toolkit.UbuntuAnimation.FastDuration : 0
34+ property real transitionDuration: panel.animate ? panel.animateDuration : 0
35
36 property string previousState: ""
37 property int movingDelta

Subscribers

People subscribed via source and target branches

to status/vote changes: