Merge lp:~nik90/ubuntu-clock-app/update-default-alarm-sound into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 334
Merged at revision: 333
Proposed branch: lp:~nik90/ubuntu-clock-app/update-default-alarm-sound
Merge into: lp:ubuntu-clock-app
Diff against target: 33 lines (+3/-2)
2 files modified
app/alarm/EditAlarmPage.qml (+2/-2)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/update-default-alarm-sound
Reviewer Review Type Date Requested Status
Bartosz Kosiorek Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+267953@code.launchpad.net

Commit message

Changed default alarm sound to "Alarm clock"

Description of the change

Changed default alarm sound to "Alarm clock".

Please do note that this sound file will not land in Ubuntu Vivid. It will be part of the stable phone images from OTA-6. So when testing on vivid desktop, expect the alarm sound to be invalid as it won't be present in the /usr/share/sounds/ubuntu/ringtones folder.

If clock app update lands before OTA-6, that's fine since indicator-datetime will automatically play the next available alarm sound (Suru Arpeggio).

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

I tested it on my BQ E4.5 phone with new alarm sound, and it is not ringing.

Only vibration is working.
So this changes is not backward compatible.

review: Needs Fixing
334. By Nekhelesh Ramananthan

Merged lp:ubuntu-clock-app

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> I tested it on my BQ E4.5 phone with new alarm sound, and it is not ringing.
>
> Only vibration is working.
> So this changes is not backward compatible.

I just tested this on my Nexus 4 running the latest image (not stable) and when I tried an invalid sound, it just defaults to "Suru arpgeggio" sound when the alarm rings. Not sure why yours didnt ring. Can you try again with clock app from trunk and this branch?

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

It is working for me correctly. Previously I have volume of alarm tone set to low, which was causing these problems.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/EditAlarmPage.qml'
2--- app/alarm/EditAlarmPage.qml 2015-06-03 22:49:29 +0000
3+++ app/alarm/EditAlarmPage.qml 2015-08-13 17:00:34 +0000
4@@ -207,7 +207,7 @@
5 When folder model is completely loaded, proceed to perform
6 the following operations,
7
8- if new alarm, then set the sound name as "Suru arpeggio" and
9+ if new alarm, then set the sound name as "Alarm clock" and
10 retrieve the sound path from the folder model to assign to
11 the alarm model sound property.
12
13@@ -298,7 +298,7 @@
14 objectName: "alarmSound"
15
16 // Default Alarm Sound for new alarms
17- property string _soundName: "Suru arpeggio"
18+ property string _soundName: "Alarm clock"
19
20 text: i18n.tr("Sound")
21 onClicked: pageStack.push(Qt.resolvedUrl("AlarmSound.qml"), {
22
23=== modified file 'debian/changelog'
24--- debian/changelog 2015-08-12 21:01:20 +0000
25+++ debian/changelog 2015-08-13 17:00:34 +0000
26@@ -9,6 +9,7 @@
27 * Fixed the confusing behavior of the confirmation button (LP: #1408015)
28 * Added README.mergeproposal checklist to help with the review process.
29 * Fix alarm interval information being inconsistent (LP: #1466000)
30+ * Changed default alarm sound (LP: #1354370)
31
32 [Victor Thompson]
33 * Show all README files in QtCreator

Subscribers

People subscribed via source and target branches