Merge lp:~nik90/ubuntu-clock-app/unload-innerclocktexture into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 158
Merged at revision: 157
Proposed branch: lp:~nik90/ubuntu-clock-app/unload-innerclocktexture
Merge into: lp:ubuntu-clock-app
Prerequisite: lp:~nik90/ubuntu-clock-app/dynamic-pageheadstate-load
Diff against target: 42 lines (+14/-6)
2 files modified
app/components/ClockCircle.qml (+12/-6)
debian/changelog (+2/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/unload-innerclocktexture
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+238630@code.launchpad.net

This proposal supersedes a proposal from 2014-10-16.

Commit message

Unloaded inner clock background texture when not required and set its smoothness to false to improve start up animation.

Description of the change

Unloaded inner clock background texture when not required and set its smoothness to false to improve start up animation.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm, great work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/ClockCircle.qml'
2--- app/components/ClockCircle.qml 2014-09-20 10:47:21 +0000
3+++ app/components/ClockCircle.qml 2014-10-16 21:47:58 +0000
4@@ -78,13 +78,19 @@
5 }
6 }
7
8- Image {
9+ Loader {
10+ id: _innerBackgroundLoader
11+ anchors.fill: parent
12+ sourceComponent: !isOuter ? _innerBackground : undefined
13+ }
14+
15+ Component {
16 id: _innerBackground
17-
18- visible: !isOuter
19- anchors.fill: parent
20- fillMode: Image.PreserveAspectFit
21- source: "../graphics/Inner_Clock_Texture.png"
22+ Image {
23+ smooth: false
24+ fillMode: Image.PreserveAspectFit
25+ source: "../graphics/Inner_Clock_Texture.png"
26+ }
27 }
28
29 /*
30
31=== modified file 'debian/changelog'
32--- debian/changelog 2014-10-16 21:47:58 +0000
33+++ debian/changelog 2014-10-16 21:47:58 +0000
34@@ -23,6 +23,8 @@
35 creation time (performance).
36 * Dynamically load/unload the search mode in world city list and multiselect view in
37 alarm page which reduces the creation time by a few ms.
38+ * Unload the inner clock texture when not required. Inner clock texture smooth is
39+ now set to false to improve startup animation.
40 * Customised splash screen (white background) (LP: #1377638)
41
42 [Akiva Shammai Avraham]

Subscribers

People subscribed via source and target branches