Merge lp:~nik90/ubuntu-clock-app/temp-fixes into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 69
Merged at revision: 69
Proposed branch: lp:~nik90/ubuntu-clock-app/temp-fixes
Merge into: lp:ubuntu-clock-app
Diff against target: 26 lines (+4/-1)
2 files modified
app/clock/ClockPage.qml (+3/-0)
app/ubuntu-clock-app.qml (+1/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/temp-fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Leo Arias (community) code review, compiled and viewed the labels. Approve
Review via email: mp+232315@code.launchpad.net

Commit message

Temporarily hides the location string and sets the bottom edge hint to "Alarms" until both these features are implemented.

Description of the change

Temporarily hides the location string and sets the bottom edge hint to "Alarms" until both these features are implemented.

I generally don't like hacks like this, but these will be removed by the next promotion image.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Thanks nik.

review: Approve (code review, compiled and viewed the labels.)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/clock/ClockPage.qml'
2--- app/clock/ClockPage.qml 2014-08-24 12:47:50 +0000
3+++ app/clock/ClockPage.qml 2014-08-26 20:31:13 +0000
4@@ -123,6 +123,9 @@
5 opacity: settingsIcon.opacity
6 spacing: units.gu(1)
7
8+ // TODO: Remove this once user location finding is implemented
9+ visible: false
10+
11 anchors {
12 top: date.bottom
13 topMargin: units.gu(1)
14
15=== modified file 'app/ubuntu-clock-app.qml'
16--- app/ubuntu-clock-app.qml 2014-08-24 12:47:50 +0000
17+++ app/ubuntu-clock-app.qml 2014-08-26 20:31:13 +0000
18@@ -100,7 +100,7 @@
19 #TODO: The bottom edge title should reflect the time to the next
20 alarm. For instance it should read "Next alarm in 9h23m".
21 */
22- bottomEdgeTitle: i18n.tr("Next Alarm in ..")
23+ bottomEdgeTitle: i18n.tr("Alarms")
24 bottomEdgePageComponent: AlarmPage {}
25 }
26 }

Subscribers

People subscribed via source and target branches