Merge lp:~nik90/ubuntu-clock-app/restore-back-multimode into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 123
Merged at revision: 124
Proposed branch: lp:~nik90/ubuntu-clock-app/restore-back-multimode
Merge into: lp:ubuntu-clock-app
Diff against target: 60 lines (+9/-24)
1 file modified
app/alarm/AlarmPage.qml (+9/-24)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/restore-back-multimode
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+236113@code.launchpad.net

Commit message

Restores the default back button in the alarm multiselect mode due to recent update by design.

Description of the change

Restores the default back button in the alarm multiselect mode due to recent update by design on bug 1370146.

Previously we used a custom back button in order to add a label below the back button icon. This is no longer needed. So this MP removes the custom back button and uses the SDK provided one.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

lgtm

review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Thanks for the review :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmPage.qml'
2--- app/alarm/AlarmPage.qml 2014-09-25 20:10:43 +0000
3+++ app/alarm/AlarmPage.qml 2014-09-26 12:26:59 +0000
4@@ -54,28 +54,17 @@
5 when: alarmListView.isInSelectionMode
6
7 backAction: Action {
8- visible: false
9+ iconName: "back"
10+ text: i18n.tr("Back")
11+ onTriggered: {
12+ alarmListView.cancelSelection()
13+ }
14 }
15
16 contents: Item {
17- anchors.fill: parent ? parent : null
18- anchors.leftMargin: units.gu(-1)
19-
20- HeaderButton {
21- id: backButton
22-
23- anchors {
24- left: parent.left
25- verticalCenter: parent.verticalCenter
26- }
27-
28- iconName: "back"
29- text: i18n.tr("Back")
30-
31- onTriggered: {
32- alarmListView.cancelSelection()
33- }
34- }
35+ anchors.right: parent ? parent.right: undefined
36+ height: parent ? parent.height : undefined
37+ width: childrenRect.width
38
39 HeaderButton {
40 id: selectButton
41@@ -83,7 +72,6 @@
42 anchors {
43 right: deleteButton.left
44 rightMargin: units.gu(1)
45- verticalCenter: parent.verticalCenter
46 }
47
48 text: {
49@@ -114,10 +102,7 @@
50 HeaderButton {
51 id: deleteButton
52
53- anchors {
54- right: parent.right
55- verticalCenter: parent.verticalCenter
56- }
57+ anchors.right: parent.right
58
59 iconName: "delete"
60 text: i18n.tr("Delete")

Subscribers

People subscribed via source and target branches