Merge lp:~nik90/ubuntu-clock-app/pot-file-oct10 into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: David Planella
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~nik90/ubuntu-clock-app/pot-file-oct10
Merge into: lp:ubuntu-clock-app
Diff against target: 159 lines (+47/-34)
2 files modified
app/worldclock/WorldCityList.qml (+1/-1)
po/com.ubuntu.clock.pot (+46/-33)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/pot-file-oct10
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+237938@code.launchpad.net

Commit message

Pot file update and online city search url version bump

Description of the change

Just a regular pot file update and a version bump to the online search url.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

LGTM

review: Approve
Revision history for this message
David Planella (dpm) wrote :

LGTM, thanks!

Just a quick comment: I'd suggest to make the version number a cmake variable, so that the code doesn't need to be updated on new releases. You could put the cmake variable in a .js.in file that gets automatically updated with the right version on build, and then the QML file reads the generated .js file.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/worldclock/WorldCityList.qml'
2--- app/worldclock/WorldCityList.qml 2014-09-26 11:36:12 +0000
3+++ app/worldclock/WorldCityList.qml 2014-10-10 10:57:33 +0000
4@@ -104,7 +104,7 @@
5 var url = String("%1%2%3")
6 .arg("http://geoname-lookup.ubuntu.com/?query=")
7 .arg(searchField.text)
8- .arg("&app=com.ubuntu.clock.devel&version=3.0")
9+ .arg("&app=com.ubuntu.clock&version=3.2.x")
10 console.log("Online URL: " + url)
11 jsonTimeZoneModel.source = Qt.resolvedUrl(url)
12 }
13
14=== modified file 'po/com.ubuntu.clock.pot'
15--- po/com.ubuntu.clock.pot 2014-10-09 10:16:42 +0000
16+++ po/com.ubuntu.clock.pot 2014-10-10 10:57:33 +0000
17@@ -8,7 +8,7 @@
18 msgstr ""
19 "Project-Id-Version: \n"
20 "Report-Msgid-Bugs-To: \n"
21-"POT-Creation-Date: 2014-10-09 12:00+0200\n"
22+"POT-Creation-Date: 2014-10-10 12:54+0200\n"
23 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
24 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
25 "Language-Team: LANGUAGE <LL@li.org>\n"
26@@ -17,61 +17,46 @@
27 "Content-Type: text/plain; charset=CHARSET\n"
28 "Content-Transfer-Encoding: 8bit\n"
29
30-#: ../app/alarm/AlarmDelegate.qml:136
31-#, qt-format
32-msgid "in %1d %1h %2m"
33-msgstr ""
34-
35-#: ../app/alarm/AlarmDelegate.qml:145
36-#, qt-format
37-msgid "in %1h %2m"
38-msgstr ""
39-
40-#: ../app/alarm/AlarmDelegate.qml:153
41-#, c-format, qt-format
42-msgid "in %1m"
43-msgstr ""
44-
45 #: ../app/alarm/AlarmLabel.qml:30 ../app/alarm/AlarmLabel.qml:56
46-#: ../app/alarm/EditAlarmPage.qml:300
47+#: ../app/alarm/EditAlarmPage.qml:299
48 msgid "Label"
49 msgstr ""
50
51-#: ../app/alarm/AlarmList.qml:81 ../app/alarm/AlarmPage.qml:108
52-#: ../app/worldclock/UserWorldCityList.qml:103
53+#: ../app/alarm/AlarmList.qml:78 ../app/alarm/AlarmPage.qml:110
54+#: ../app/worldclock/UserWorldCityList.qml:101
55 msgid "Delete"
56 msgstr ""
57
58-#: ../app/alarm/AlarmPage.qml:26 ../app/ubuntu-clock-app.qml:139
59+#: ../app/alarm/AlarmPage.qml:28
60 msgid "Alarms"
61 msgstr ""
62
63-#: ../app/alarm/AlarmPage.qml:43 ../app/alarm/EditAlarmPage.qml:47
64-#: ../app/alarm/EditAlarmPage.qml:174
65+#: ../app/alarm/AlarmPage.qml:45 ../app/alarm/EditAlarmPage.qml:46
66+#: ../app/alarm/EditAlarmPage.qml:173
67 msgid "Alarm"
68 msgstr ""
69
70-#: ../app/alarm/AlarmPage.qml:58 ../app/worldclock/WorldCityList.qml:68
71+#: ../app/alarm/AlarmPage.qml:60 ../app/worldclock/WorldCityList.qml:68
72 msgid "Back"
73 msgstr ""
74
75-#: ../app/alarm/AlarmPage.qml:79
76+#: ../app/alarm/AlarmPage.qml:81
77 msgid "Select None"
78 msgstr ""
79
80-#: ../app/alarm/AlarmPage.qml:81 ../app/alarm/AlarmRepeat.qml:35
81+#: ../app/alarm/AlarmPage.qml:83 ../app/alarm/AlarmRepeat.qml:35
82 msgid "Select All"
83 msgstr ""
84
85-#: ../app/alarm/AlarmPage.qml:137
86+#: ../app/alarm/AlarmPage.qml:140
87 msgid "No saved alarms"
88 msgstr ""
89
90-#: ../app/alarm/AlarmPage.qml:138
91+#: ../app/alarm/AlarmPage.qml:141
92 msgid "Tap the + icon to add an alarm"
93 msgstr ""
94
95-#: ../app/alarm/AlarmRepeat.qml:31 ../app/alarm/EditAlarmPage.qml:290
96+#: ../app/alarm/AlarmRepeat.qml:31 ../app/alarm/EditAlarmPage.qml:289
97 msgid "Repeat"
98 msgstr ""
99
100@@ -109,7 +94,7 @@
101 msgid "Change time and date"
102 msgstr ""
103
104-#: ../app/alarm/AlarmSound.qml:28 ../app/alarm/EditAlarmPage.qml:313
105+#: ../app/alarm/AlarmSound.qml:28 ../app/alarm/EditAlarmPage.qml:312
106 msgid "Sound"
107 msgstr ""
108
109@@ -129,19 +114,47 @@
110 msgid "Daily"
111 msgstr ""
112
113-#: ../app/alarm/EditAlarmPage.qml:40
114+#: ../app/alarm/AlarmUtils.qml:55
115+msgid "No active alarms"
116+msgstr ""
117+
118+#: ../app/alarm/AlarmUtils.qml:72
119+#, qt-format
120+msgid "Next Alarm %1"
121+msgstr ""
122+
123+#: ../app/alarm/AlarmUtils.qml:79
124+msgid "Alarm Passed"
125+msgstr ""
126+
127+#: ../app/alarm/AlarmUtils.qml:88
128+#, qt-format
129+msgid "in %1d %2h %3m"
130+msgstr ""
131+
132+#: ../app/alarm/AlarmUtils.qml:97
133+#, qt-format
134+msgid "in %1h %2m"
135+msgstr ""
136+
137+#: ../app/alarm/AlarmUtils.qml:105
138+#, c-format, qt-format
139+msgid "in %1m"
140+msgstr ""
141+
142+#: ../app/alarm/EditAlarmPage.qml:39
143 msgid "New alarm"
144 msgstr ""
145
146-#: ../app/alarm/EditAlarmPage.qml:40
147+#: ../app/alarm/EditAlarmPage.qml:39
148 msgid "Edit alarm"
149 msgstr ""
150
151-#: ../app/alarm/EditAlarmPage.qml:337
152+#: ../app/alarm/EditAlarmPage.qml:336
153 msgid "Delete alarm"
154 msgstr ""
155
156-#: ../app/clock/ClockPage.qml:143
157+#: ../app/clock/ClockPage.qml:150
158 msgid "Location"
159 msgstr ""
160

Subscribers

People subscribed via source and target branches