Merge lp:~nik90/ubuntu-clock-app/performance-patch-1 into lp:ubuntu-clock-app/saucy
Proposed by
Nekhelesh Ramananthan
Status: | Merged |
---|---|
Approved by: | Nekhelesh Ramananthan |
Approved revision: | 350 |
Merged at revision: | 347 |
Proposed branch: | lp:~nik90/ubuntu-clock-app/performance-patch-1 |
Merge into: | lp:ubuntu-clock-app/saucy |
Diff against target: |
394 lines (+119/-46) 7 files modified
alarm/AlarmPage.qml (+3/-1) clock/ClockPage.qml (+6/-6) clock/WorldClock.qml (+2/-2) common/SettingsPage.qml (+24/-3) stopwatch/StopwatchPage.qml (+5/-1) timer/TimerPage.qml (+5/-1) ubuntu-clock-app.qml (+74/-32) |
To merge this branch: | bzr merge lp:~nik90/ubuntu-clock-app/performance-patch-1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Riccardo Padovani | Approve | ||
Alan Pope πΊπ§π± π¦ (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+207119@code.launchpad.net |
Commit message
Improved the IDLE performance of the clock app. Added a settings option to hide/show the seconds hand.
Description of the change
Dynamically loads tabs using QML Loaders ensuring there is only one tab in memory at any time. This has improve the IDLE performance of the clock app significantly. It has resulted in the IDLE CPU usage reduction from 2.6-4.0% to 0%.
It also adds an settings option to show/hide the seconds hand.
To post a comment you must log in.
FAILED: Continuous integration, rev:349 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/264/ 91.189. 93.70:8080/ job/generic- mediumtests- trusty/ 1406 91.189. 93.70:8080/ job/ubuntu- clock-app- raring- amd64-ci/ 264 91.189. 93.70:8080/ job/ubuntu- clock-app- saucy-amd64- ci/264 91.189. 93.70:8080/ job/ubuntu- clock-app- trusty- amd64-ci/ 182
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/264/ rebuild
http://