Ubuntu Clock App

Merge lp:~nik90/ubuntu-clock-app/lock-portrait-orientation into lp:ubuntu-clock-app

  1. lock-portrait-orientation
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan on 2015-06-16
Status: Merged
Approved by: Nekhelesh Ramananthan on 2015-06-18
Approved revision: 279
Merged at revision: 282
Proposed branch: lp:~nik90/ubuntu-clock-app/lock-portrait-orientation
Merge into: lp:ubuntu-clock-app
Diff against target: 20 lines (+2/-0)
2 files modified
debian/changelog (+1/-0)
ubuntu-clock-app.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/lock-portrait-orientation
Reviewer Review Type Date Requested Status
Victor Thompson 2015-06-16 Approve on 2015-06-17
Jonas G. Drange (community) Needs Information on 2015-06-17
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-06-16
Review via email: mp+262053@code.launchpad.net

Commit Message

Locked clock app to the portrait orientation

Description of the Change

Locked clock app to the portrait orientation

To post a comment you must log in.
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Victor Thompson (vthompson) wrote :

Even with the new desktop file flag this still allows the app to undergo rotation on rc-proposed. I'm not sure what's going on, the same flag seems to work in other apps (ie, volleyball 2D).

review: Needs Information
Jonas G. Drange (jonas-drange) wrote :

Why is not the fix implementing a flickable?

review: Needs Information
Nekhelesh Ramananthan (nik90) wrote :

@Jonas, Because while the flickable might make the alarm page useable in landscape mode, clock app was always meant to run in the side-stage and never designed for the landscape mode. Clock app is also in maintenance mode until pretty much 16.04 when we get Timer and Stopwatch designs. Until then I would rather keep it locked in portrait mode and not make any invasive code changes for landscape support.

Nekhelesh Ramananthan (nik90) wrote :

@Victor, On testing with ubuntu-touch/rc-proposed/ubuntu r162, the lock to portrait form works as expected. Can you try this MP again with the above image pls? FYI, r163 image is a OTA-4 image for testing purposed, so ensure that you're at r162.

Victor Thompson (vthompson) wrote :

Ok, I'm on image r164 and this MP works as expected. I'm not sure what happened previously--I was on r163 I presume.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-05-26 14:40:39 +0000
3+++ debian/changelog 2015-06-16 07:20:29 +0000
4@@ -22,6 +22,7 @@
5 location access (LP: #1393827)
6 * Increased date font size (LP: #1432736)
7 * Fixed empty state component width warnings
8+ * Locked clock app orientation to portrait (LP: #1465457)
9
10 [Penk Chen]
11 * Fixed DigitalMode time being empty in chineese locale (LP: #1458808)
12
13=== modified file 'ubuntu-clock-app.desktop.in.in'
14--- ubuntu-clock-app.desktop.in.in 2014-10-15 18:24:08 +0000
15+++ ubuntu-clock-app.desktop.in.in 2015-06-16 07:20:29 +0000
16@@ -10,3 +10,4 @@
17 X-Ubuntu-Touch=true
18 X-Ubuntu-Default-Department-ID=accessories
19 X-Ubuntu-Splash-Color=#F5F5F5
20+X-Ubuntu-Supported-Orientations=portrait

Subscribers

People subscribed via source and target branches