Merge lp:~nik90/ubuntu-clock-app/lock-portrait-orientation into lp:ubuntu-clock-app

[Nekhelesh Ramananthan]

Locked clock app to the portrait orientation

Locked clock app to the portrait orientation

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:279
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/667/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/13
        deb: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/13/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/667/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

Even with the new desktop file flag this still allows the app to undergo rotation on rc-proposed. I'm not sure what's going on, the same flag seems to work in other apps (ie, volleyball 2D).

review: Needs Information

[Jonas G. Drange (jonas-drange)]

Why is not the fix implementing a flickable?

review: Needs Information

[Nekhelesh Ramananthan (nik90)]

@Jonas, Because while the flickable might make the alarm page useable in landscape mode, clock app was always meant to run in the side-stage and never designed for the landscape mode. Clock app is also in maintenance mode until pretty much 16.04 when we get Timer and Stopwatch designs. Until then I would rather keep it locked in portrait mode and not make any invasive code changes for landscape support.

[Nekhelesh Ramananthan (nik90)]

@Victor, On testing with ubuntu-touch/rc-proposed/ubuntu r162, the lock to portrait form works as expected. Can you try this MP again with the above image pls? FYI, r163 image is a OTA-4 image for testing purposed, so ensure that you're at r162.

[Victor Thompson (vthompson)]

Ok, I'm on image r164 and this MP works as expected. I'm not sure what happened previously--I was on r163 I presume.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2015-05-26 14:40:39 +0000
+++ debian/changelog	2015-06-16 07:20:29 +0000
@@ -22,6 +22,7 @@
     location access (LP: #1393827)
   * Increased date font size (LP: #1432736)
   * Fixed empty state component width warnings
+  * Locked clock app orientation to portrait (LP: #1465457)
   
   [Penk Chen]
   * Fixed DigitalMode time being empty in chineese locale (LP: #1458808)

=== modified file 'ubuntu-clock-app.desktop.in.in'
--- ubuntu-clock-app.desktop.in.in	2014-10-15 18:24:08 +0000
+++ ubuntu-clock-app.desktop.in.in	2015-06-16 07:20:29 +0000
@@ -10,3 +10,4 @@
 X-Ubuntu-Touch=true
 X-Ubuntu-Default-Department-ID=accessories
 X-Ubuntu-Splash-Color=#F5F5F5
+X-Ubuntu-Supported-Orientations=portrait