Merge lp:~nik90/ubuntu-clock-app/intltool-required into lp:ubuntu-clock-app

[Nekhelesh Ramananthan]

Make missing intltool a fatal configuration error.

When a developer doesn't have the intltool package installed, the cmake configurations fails silently showing a cryptic message [CMakeFiles/ubuntu-clock-app.desktop] Error 127. I noticed a MP by Michael Sawiq at https://code.launchpad.net/~saviq/webbrowser-app/intltool-required/+merge/233531 where the intltool is necessary for the cmake build to succeed and if not show a proper error message.

This MP mimics that.

[lp:~nik90/ubuntu-clock-app/intltool-required]

128. By Nekhelesh Ramananthan on 2014-09-27

Typo fix

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:128
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/505/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/576
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/576/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/152

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/505/rebuild

review: Approve (continuous-integration)

[David Planella (dpm)]

Looks good to me, thanks!

Unrelated to this merge, I think in the long run we should create a .cmake module that we can just drop into projects to make internationalization simpler. I've looked at existing Gettext.cmake modules around the net, but they seem quite complex and to do things that we don't need.

review: Approve

[Nekhelesh Ramananthan (nik90)]

Thanks for the approval. And yes I think a generic cmake module should be made to simplify this process and also make it uniform throughout the apps. I think we should improve the template of the pot file though since at the moment there are some fields like,

# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR Canonical Ltd.
# This file is distributed under the same license as the PACKAGE package.
# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
#

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2014-09-26 16:24:55 +0000
+++ CMakeLists.txt	2014-09-27 10:37:07 +0000
@@ -1,7 +1,15 @@
 project(com.ubuntu.clock C CXX)
 cmake_minimum_required(VERSION 2.8.9)
+
 find_program(INTLTOOL_MERGE intltool-merge)
+if(NOT INTLTOOL_MERGE)
+    message(FATAL_ERROR "Could not find intltool-merge, please install the intltool package")
+endif()
+
 find_program(INTLTOOL_EXTRACT intltool-extract)
+if(NOT INTLTOOL_EXTRACT)
+    message(FATAL_ERROR "Could not find intltool-extract, please install the intltool package")
+endif()
 
 set (UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")
 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")