Merge lp:~nik90/ubuntu-clock-app/increase-clockmode-switch-speed into lp:ubuntu-clock-app

[Nekhelesh Ramananthan]

Made clock mode switch animation twice as fast based on public user testing results.

Made clock mode switch animation twice as fast based on public user testing results. Also changed the NumberAnimation to UbuntuNumberAnimation to maintain consistency.

==== Checklist ====

* Are there any related MPs required for this MP to build/function as expected? Please list.

None Required.

* Is your branch in sync with latest trunk? (e.g. bzr pull lp:ubuntu-clock-app -> no changes)

Yes it is.

* Did the tests run successfully (QML and AP)?

Yes

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* What device (or emulator) has your component test plan been executed successfully on?

x86 Emulator and N4 Device

* If you changed the UI, was the change specified/approved by design?

Yes this was approved by Giorgio after testing it on his N4 device.

* What manual tests are relevant for this MP?

- Open the clock app and switch from analog to digital mode
- The animation must be twice as fast as the old one

* If you changed UI labels, did you update the pot file?

None

* Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/Clock

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:88
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/445/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/224
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/224/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/92

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/445/rebuild

review: Approve (continuous-integration)

[Victor Thompson (vthompson)]

Assuming the bug report filed by design was to indicate that the speed should be twice as fast, this looks good.

review: Approve

[Nekhelesh Ramananthan (nik90)]

Actually I don't have access to the design document attached to the bug report :P as well. So this will have to wait until monday to get design approval and merge. But thnx for the quick code review.

review: Needs Fixing

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:89
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/450/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/245
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/245/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-utopic-amd64-ci/97

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/450/rebuild

review: Approve (continuous-integration)

[Nekhelesh Ramananthan (nik90)]

review: Abstain

[PS Jenkins bot (ps-jenkins)]

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-clock-app-autolanding/59/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/379/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-clock-app-utopic-amd64-autolanding/38
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/518/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/591
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12951

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'app/components/AnalogShadow.qml'
--- app/components/AnalogShadow.qml	2014-08-24 12:47:50 +0000
+++ app/components/AnalogShadow.qml	2014-09-09 10:23:20 +0000
@@ -74,10 +74,10 @@
     }
 
     transitions: Transition {
-        NumberAnimation {
+        UbuntuNumberAnimation {
             target: rotation
             property: "angle"
-            duration: 666
+            duration: 333
         }
     }
 }

=== modified file 'app/components/Clock.qml'
--- app/components/Clock.qml	2014-08-24 12:47:50 +0000
+++ app/components/Clock.qml	2014-09-09 10:23:20 +0000
@@ -190,18 +190,18 @@
             }
         }
 
-        PropertyAnimation {
+        UbuntuNumberAnimation {
             target: bottomShadow
             property: "opacity"
-            duration: 333
+            duration: 166
             from: 1
             to: 0
         }
 
-        PropertyAnimation {
+        UbuntuNumberAnimation {
             target: upperShadow
             property: "opacity"
-            duration: 333
+            duration: 166
             from: 0
             to: 1
         }

=== modified file 'app/components/DigitalShadow.qml'
--- app/components/DigitalShadow.qml	2014-08-24 12:47:50 +0000
+++ app/components/DigitalShadow.qml	2014-09-09 10:23:20 +0000
@@ -74,10 +74,10 @@
     }
 
     transitions: Transition {
-        NumberAnimation {
+        UbuntuNumberAnimation {
             target: rotation
             property: "angle"
-            duration: 666
+            duration: 333
         }
     }
 }

=== modified file 'debian/changelog'
--- debian/changelog	2014-09-08 22:22:57 +0000
+++ debian/changelog	2014-09-09 10:23:20 +0000
@@ -29,6 +29,7 @@
   * Added pressed visual state to the settings button (LP: #1364553)
   * Fixed no UI hint being show to add cities (LP: #1362263)
   * Fixed add world city being triggered accidentally (LP: #1359180)
+  * Fixed clock mode animations being too slow (LP: #1365440)
   * Added alarm snooze settings (LP: #1354400)
   * Fixed default alarm label not being translatable (LP: #1365012)