Merge lp:~nik90/ubuntu-clock-app/improved-bottomedge-header into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 251
Merged at revision: 251
Proposed branch: lp:~nik90/ubuntu-clock-app/improved-bottomedge-header
Merge into: lp:ubuntu-clock-app
Diff against target: 90 lines (+21/-11)
3 files modified
app/alarm/AlarmPage.qml (+8/-0)
debian/changelog (+1/-0)
po/com.ubuntu.clock.pot (+12/-11)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/improved-bottomedge-header
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+256129@code.launchpad.net

Commit message

Improves the bottom edge header by showing the back button chevron pointing downwards as suggested by design.

Description of the change

Improves the bottom edge header by showing the back button chevron pointing downwards as suggested by design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Nice! Looks good to me.

review: Approve
251. By Nekhelesh Ramananthan

merged lp:ubuntu-clock-app

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmPage.qml'
2--- app/alarm/AlarmPage.qml 2015-03-05 12:54:28 +0000
3+++ app/alarm/AlarmPage.qml 2015-04-14 23:56:21 +0000
4@@ -36,6 +36,14 @@
5 head: alarmPage.head
6 when: !alarmListView.isInSelectionMode
7
8+ backAction: Action {
9+ iconName: "down"
10+ text: i18n.tr("Back")
11+ onTriggered: {
12+ pageStack.pop()
13+ }
14+ }
15+
16 actions: [
17 Action {
18 objectName: "addAlarmAction"
19
20=== modified file 'debian/changelog'
21--- debian/changelog 2015-04-14 11:08:01 +0000
22+++ debian/changelog 2015-04-14 23:56:21 +0000
23@@ -17,6 +17,7 @@
24 * Renabled create alarm tests on device which were disabled due to upstream bug
25 in autopilot. (LP: #1426108)
26 * Fixed timezone difference label overflowing into the clock (LP: #1440732)
27+ * Improved bottom edge header by correcting the direction of the chevron (LP: #1432696)
28
29 [Brendan Donegan]
30 * Fixed AP failure by waiting for the bottom edge tip visible property to be true
31
32=== modified file 'po/com.ubuntu.clock.pot'
33--- po/com.ubuntu.clock.pot 2015-04-14 11:08:01 +0000
34+++ po/com.ubuntu.clock.pot 2015-04-14 23:56:21 +0000
35@@ -8,7 +8,7 @@
36 msgstr ""
37 "Project-Id-Version: \n"
38 "Report-Msgid-Bugs-To: \n"
39-"POT-Creation-Date: 2015-04-14 13:07+0200\n"
40+"POT-Creation-Date: 2015-04-15 01:55+0200\n"
41 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
42 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
43 "Language-Team: LANGUAGE <LL@li.org>\n"
44@@ -23,7 +23,7 @@
45 msgid "Label"
46 msgstr ""
47
48-#: ../app/alarm/AlarmList.qml:78 ../app/alarm/AlarmPage.qml:117
49+#: ../app/alarm/AlarmList.qml:78 ../app/alarm/AlarmPage.qml:125
50 #: ../app/worldclock/UserWorldCityList.qml:101
51 msgid "Delete"
52 msgstr ""
53@@ -32,28 +32,29 @@
54 msgid "Alarms"
55 msgstr ""
56
57-#: ../app/alarm/AlarmPage.qml:43 ../app/alarm/EditAlarmPage.qml:44
58+#: ../app/alarm/AlarmPage.qml:41 ../app/alarm/AlarmPage.qml:66
59+#: ../app/worldclock/WorldCityList.qml:80
60+msgid "Back"
61+msgstr ""
62+
63+#: ../app/alarm/AlarmPage.qml:51 ../app/alarm/EditAlarmPage.qml:44
64 #: ../app/alarm/EditAlarmPage.qml:166
65 msgid "Alarm"
66 msgstr ""
67
68-#: ../app/alarm/AlarmPage.qml:58 ../app/worldclock/WorldCityList.qml:80
69-msgid "Back"
70-msgstr ""
71-
72-#: ../app/alarm/AlarmPage.qml:87
73+#: ../app/alarm/AlarmPage.qml:95
74 msgid "Select None"
75 msgstr ""
76
77-#: ../app/alarm/AlarmPage.qml:89 ../app/alarm/AlarmRepeat.qml:38
78+#: ../app/alarm/AlarmPage.qml:97 ../app/alarm/AlarmRepeat.qml:38
79 msgid "Select All"
80 msgstr ""
81
82-#: ../app/alarm/AlarmPage.qml:154
83+#: ../app/alarm/AlarmPage.qml:162
84 msgid "No saved alarms"
85 msgstr ""
86
87-#: ../app/alarm/AlarmPage.qml:155
88+#: ../app/alarm/AlarmPage.qml:163
89 msgid "Tap the + icon to add an alarm"
90 msgstr ""
91

Subscribers

People subscribed via source and target branches