Merge lp:~nik90/ubuntu-clock-app/fix-warning-message into lp:ubuntu-clock-app

[Nekhelesh Ramananthan]

Fixed the warning related to undefined width in the AlarmPage.qml and corrected the delete icon's right margin in the alarm multiselect mode.

This MP implements the following,
- Fixes the warning related to undefined width in the AlarmPage.qml
- Corrects the delete icon's right margin in the alarm multiselect mode

Incorrect right margin screenshot
-> https://imgur.com/Ypf9a3X

Correct right margin screenshot implemented in this MP
-> https://imgur.com/r7zcHhR

[Kill Animals (kill-animals)]

margin looks fine

qml: DEPRECATED use of Panel.opened property. This property will be made read-only,
                please use the opened property of the Page tools or use Panel.open() and Panel.close().
qml: Debug: Queue: Now has: 0 tracks
qml: Shuffle: true
qml: Debug: onCountChanged: 0
APP_ID isn't set, the handler can not be registered
UCUriHandler: Empty "APP_ID" environment variable, ignoring.
qml: WARNING: Sheets are deprecated. Consider using Dialog, Popover or PageStack instead.
qml: Debug: Version 1.2
qml: Debug: Arguments on startup: Debug: false
qml: Debug: Arguments on startup: Debug: false and file:
qml: INITIALIZED in tracks
qml: Playlist DB is version 1.3
qml: DB: Restore {}
qml: called LibraryListModel::filterRecent()
qml: Time:2014-10-11T00:21:10.111, Key:Angel Clare, Title:Angel Clare, Title2:Art Garfunkel, Type:album, Art:image://albumart/artist=Art%20Garfunkel&album=Angel%20Clare
qml: Time:2014-10-10T22:02:26.047, Key:hoieh, Title:hoieh, Title2:Playlist, Type:playlist, Art:
qml: Time:2014-10-10T21:47:23.506, Key:, Title:, Title2:, Type:album, Art:image://albumart/artist=&album=
D-Bus error: "Could not get thumbnail"
qml: {"art":"image://albumart/artist=Art%20Garfunkel&album=Angel%20Clare","key":"Angel Clare","time":"2014-10-11T00:21:10.111","title":"Angel Clare","title2":"Art Garfunkel","type":"album"}
APP_ID isn't set, the handler ignored
qml: {"key":"hoieh","time":"2014-10-10T22:02:26.047","title":"hoieh","title2":"Playlist","type":"playlist"}
qml: {"art":"image://albumart/artist=&album=","key":"Unknown Album","time":"2014-10-10T21:47:23.506","title":"Unknown Album","title2":"Unknown Artist","type":"album"}
qml: Debug: Queue: Now has: 1 tracks
qml: Debug: MusicQueue update currentIndex:
qml: Source: file:///home/akiva/Music/Art Garfunkel - Travelling Boy.mp3
qml: Index: 0
qml: RECENT Angel ClareAngel ClareArt Garfunkelimage://albumart/artist=Art%20Garfunkel&album=Angel%20Clare
qml: RECENT add OK
qml: called LibraryListModel::filterRecent()
qml: Time:2014-10-11T00:30:29.888, Key:Angel Clare, Title:Angel Clare, Title2:Art Garfunkel, Type:album, Art:image://albumart/artist=Art%20Garfunkel&album=Angel%20Clare
qml: Time:2014-10-10T22:02:26.047, Key:hoieh, Title:hoieh, Title2:Playlist, Type:playlist, Art:
qml: Time:2014-10-10T21:47:23.506, Key:, Title:, Title2:, Type:album, Art:image://albumart/artist=&album=
qml: {"art":"image://albumart/artist=Art%20Garfunkel&album=Angel%20Clare","key":"Angel Clare","time":"2014-10-11T00:30:29.888","title":"Angel Clare","title2":"Art Garfunkel","type":"album"}
qml: Debug: Queue: Now has: 2 tracks
ShaderEffect: Property 'source' is not assigned a valid texture provider (QQuickItem*).
ShaderEffect: Property 'source' is not assigned a valid texture provider (QQuickItem*).
qml: {"key":"hoieh","time":"2014-10-10T22:02:26.047","title":"hoieh","title2":"Playlist","type":"playlist"}
qml: {"art":"image://albumart/artist=&album=","key":"Unknown Album","time":"2014-10-10T21:47:23.506","title":"Unknown Album","title2":"Unknown Artist","type":"album"}
APP_ID isn't set, the handler ignored
qml: Increment UserMetrics
APP_ID isn't set, the handler ignored
file:///home/akiva/Programming/Deleteme/remix...

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:142
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/553/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/881
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/881/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/553/rebuild

review: Approve (continuous-integration)

=== modified file 'app/alarm/AlarmPage.qml'
--- app/alarm/AlarmPage.qml	2014-10-05 15:33:27 +0000
+++ app/alarm/AlarmPage.qml	2014-10-11 10:24:47 +0000
@@ -66,7 +66,6 @@
             contents: Item {
                 anchors.right: parent ? parent.right: undefined
                 height: parent ? parent.height : undefined
-                width: childrenRect.width
 
                 HeaderButton {
                     id: selectButton
@@ -105,6 +104,7 @@
                     id: deleteButton
 
                     anchors.right: parent.right
+                    anchors.rightMargin: units.gu(2)
 
                     iconName: "delete"
                     text: i18n.tr("Delete")

=== modified file 'debian/changelog'
--- debian/changelog	2014-10-10 10:19:10 +0000
+++ debian/changelog	2014-10-11 10:24:47 +0000
@@ -10,6 +10,7 @@
     only. (LP: #1377538)
   * Tweaked bottom edge to show the time to the next active alarm (LP: #1290793)
   * Synced ListItemWithActions with upstream
+  * Fixed alarm page header width warning and corrected icon spacing.
 
   [Akiva Shammai Avraham]
   * Improved the analog clock performance by updating the clock hands every second