Merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Bartosz Kosiorek
Approved revision: 352
Merged at revision: 352
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning
Merge into: lp:ubuntu-clock-app
Diff against target: 13 lines (+2/-1)
1 file modified
backend/modules/Clock/Utility/customalarmsound.h (+2/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-non-notifyable-warning
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Bartosz Kosiorek Approve
Review via email: mp+268846@code.launchpad.net

Commit message

Fixed non-notifyable warning shown when opening the edit alarm page.

Description of the change

Opening the edit alarm page used to result in the following warning shown,

QQmlExpression: Expression file:///opt/click.ubuntu.com/com.ubuntu.clock/3.5.349/share/qml/alarm/EditAlarmPage.qml:271:17 depends on non-NOTIFYable properties: CustomAlarmSound::alarmSoundDirectory

This was because the property "alarmSoundDirectory" did not notify QML of any changes since it supposed to be a constant variable. Fixed that minor issue.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Looks ok to me.

I think we could do not update changelog with such small issue.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'backend/modules/Clock/Utility/customalarmsound.h'
2--- backend/modules/Clock/Utility/customalarmsound.h 2015-08-22 21:19:54 +0000
3+++ backend/modules/Clock/Utility/customalarmsound.h 2015-08-23 10:02:01 +0000
4@@ -27,7 +27,8 @@
5
6 // READONLY Property to return the custom alarm sound directory path
7 Q_PROPERTY( QString alarmSoundDirectory
8- READ alarmSoundDirectory)
9+ READ alarmSoundDirectory
10+ CONSTANT)
11
12 public:
13 CustomAlarmSound(QObject *parent = 0);

Subscribers

People subscribed via source and target branches