Merge lp:~nik90/ubuntu-clock-app/fix-model-usage into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 173
Merged at revision: 178
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-model-usage
Merge into: lp:ubuntu-clock-app
Diff against target: 27 lines (+4/-2)
2 files modified
app/alarm/AlarmDelegate.qml (+3/-2)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-model-usage
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Zsombor Egri (community) Approve
Ubuntu Clock Developers Pending
Review via email: mp+242221@code.launchpad.net

Commit message

Fixed incorrect saving of alarm data using alarm delegate model.

Description of the change

Fixed incorrect saving of alarm data using alarm delegate model.

To post a comment you must log in.
173. By Nekhelesh Ramananthan

Reverted other unnecessary changes

Revision history for this message
Zsombor Egri (zsombi) wrote :

This looks good!

Revision history for this message
Zsombor Egri (zsombi) wrote :

And approved :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmDelegate.qml'
2--- app/alarm/AlarmDelegate.qml 2014-10-06 19:49:17 +0000
3+++ app/alarm/AlarmDelegate.qml 2014-11-19 14:56:49 +0000
4@@ -92,8 +92,9 @@
5
6 onCheckedChanged: {
7 if (checked !== model.enabled) {
8- model.enabled = checked
9- model.save()
10+ var alarmData = model
11+ alarmData.enabled = checked
12+ alarmData.save()
13 }
14 }
15
16
17=== modified file 'debian/changelog'
18--- debian/changelog 2014-11-17 15:33:53 +0000
19+++ debian/changelog 2014-11-19 14:56:49 +0000
20@@ -28,6 +28,7 @@
21 * Customised splash screen (white background) (LP: #1377638)
22 * Added manual test to check disabling of alarms.
23 * Fixed alarm string not being translatable (LP: #1380248)
24+ * Fixed the incorrect overriding of alarm delegate model value.
25
26 [Akiva Shammai Avraham]
27 * Improved the analog clock performance by updating the clock hands every second

Subscribers

People subscribed via source and target branches