Merge lp:~nik90/ubuntu-clock-app/fix-hud-actions into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 197
Merged at revision: 197
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-hud-actions
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 85 lines (+21/-32)
1 file modified
timer/TimerPage.qml (+21/-32)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-hud-actions
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+185621@code.launchpad.net

Commit message

Removed HUD actions for generic functions such as save and cancel.

Description of the change

This MP removes HUD actions for generic toolbar functions such as "Save", "Cancel". This was approved by design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'timer/TimerPage.qml'
2--- timer/TimerPage.qml 2013-09-12 17:22:30 +0000
3+++ timer/TimerPage.qml 2013-09-14 10:25:58 +0000
4@@ -36,7 +36,7 @@
5 property string tempNamePreset
6 property int pagePostion
7
8- actions: [
9+ actions:
10 Action {
11 id: addTimerAction
12 iconSource: Qt.resolvedUrl("../images/add_icon.png")
13@@ -47,36 +47,7 @@
14 reset()
15 state = "addPreset"
16 }
17- },
18-
19- Action {
20- id: saveTimerAction
21- iconSource: Qt.resolvedUrl("../images/select_icon.png")
22- text: i18n.tr("Save")
23- onTriggered: {
24- presetModel.appendPreset(tempNamePreset, namePreset.text, ((minutes * 60) + seconds), listTimerPreset.currentIndex)
25- namePreset.focus = false
26- if (listTimerPreset.currentIndex == -1) {
27- reset()
28- state = "";
29- timerAnimationContainer.contentY = presetModel.count != 0 ? units.gu(87) - timerPage.height : 0;
30- }
31- toolbarTimer.opened = false;
32- }
33- },
34-
35- Action {
36- id: cancelTimerAction
37- iconSource: Qt.resolvedUrl("../images/cancel_icon.svg")
38- text: i18n.tr("Cancel")
39- onTriggered: {
40- reset()
41- state = "";
42- toolbarTimer.opened = false;
43- timerAnimationContainer.contentY = presetModel.count != 0 ? units.gu(87) - timerPage.height : 0;
44- }
45 }
46- ]
47
48 states: [
49 State {
50@@ -378,7 +349,18 @@
51 id: editPresetToolbarButton
52 objectName: "savePresetButton"
53 visible: false
54- action: saveTimerAction
55+ iconSource: Qt.resolvedUrl("../images/select_icon.png")
56+ text: i18n.tr("Save")
57+ onTriggered: {
58+ presetModel.appendPreset(tempNamePreset, namePreset.text, ((minutes * 60) + seconds), listTimerPreset.currentIndex)
59+ namePreset.focus = false
60+ if (listTimerPreset.currentIndex == -1) {
61+ reset()
62+ timerPage.state = "";
63+ timerAnimationContainer.contentY = presetModel.count != 0 ? units.gu(87) - timerPage.height : 0;
64+ }
65+ toolbarTimer.opened = false;
66+ }
67 }
68
69 ToolbarButton {
70@@ -391,7 +373,14 @@
71 id: cancelPresetToolbarButton
72 objectName: "cancelPresetButton"
73 visible: false;
74- action: cancelTimerAction
75+ iconSource: Qt.resolvedUrl("../images/cancel_icon.svg")
76+ text: i18n.tr("Cancel")
77+ onTriggered: {
78+ reset()
79+ timerPage.state = "";
80+ toolbarTimer.opened = false;
81+ timerAnimationContainer.contentY = presetModel.count != 0 ? units.gu(87) - timerPage.height : 0;
82+ }
83 }
84 }
85 }

Subscribers

People subscribed via source and target branches