Merge lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app
Proposed by
Nekhelesh Ramananthan
Status: | Merged |
---|---|
Approved by: | Riccardo Padovani |
Approved revision: | 268 |
Merged at revision: | 269 |
Proposed branch: | lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings |
Merge into: | lp:ubuntu-clock-app |
Diff against target: |
39 lines (+5/-2) 3 files modified
app/components/EmptyState.qml (+0/-1) debian/changelog (+4/-0) po/com.ubuntu.clock.pot (+1/-1) |
To merge this branch: | bzr merge lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Riccardo Padovani | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+260173@code.launchpad.net |
Commit message
Fixed empty state component warning.
Description of the change
Fixed empty state component warning "file:/
This was fixed by removing width: parent.width since the component automatically fills the width and height of the loader and as such doesn't require an explicit declaration of size within the component itself.
Note: I also added the debian changelog entry for a previous MP that was missing it.
To post a comment you must log in.
PASSED: Continuous integration, rev:268 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/649/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2816 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 2816/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/649/ rebuild
http://