Merge lp:~nik90/ubuntu-clock-app/fix-duplicate-translation-strings into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: David Planella
Approved revision: 130
Merged at revision: 129
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-duplicate-translation-strings
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 179 lines (+55/-54)
3 files modified
clock/EasterEgg.qml (+2/-2)
clock/WorldClock.qml (+1/-1)
po/ubuntu-clock-app.pot (+52/-51)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-duplicate-translation-strings
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+173555@code.launchpad.net

Commit message

Fixes duplicate translations strings and also removed "UTC" string marked for translation which was also incorrrect.

Description of the change

Fix duplicate translations strings and also removed "UTC" string marked for translation which was also incorrrect.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, nice work!

However, I'd keep "UTC" as a translatable string. Other than that, looks good to go to me.

review: Needs Fixing
130. By Nekhelesh Ramananthan

reverted UTC translation string removal

Revision history for this message
David Planella (dpm) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clock/EasterEgg.qml'
2--- clock/EasterEgg.qml 2013-07-01 11:14:39 +0000
3+++ clock/EasterEgg.qml 2013-07-08 17:43:26 +0000
4@@ -97,7 +97,7 @@
5 anchors.horizontalCenter: parent.horizontalCenter
6 color: Constants.brightWhite;
7 fontSize: "x-large";
8- text: i18n.tr("loading")
9+ text: i18n.tr("Loading")
10 }
11
12 Rectangle {
13@@ -114,7 +114,7 @@
14 horizontalAlignment: Text.AlignHCenter
15 color: Constants.brightWhite;
16 fontSize: "x-large";
17- text: i18n.tr("loading")
18+ text: i18n.tr("Loading")
19 }
20
21 Label {
22
23=== modified file 'clock/WorldClock.qml'
24--- clock/WorldClock.qml 2013-06-21 23:36:03 +0000
25+++ clock/WorldClock.qml 2013-07-08 17:43:26 +0000
26@@ -139,7 +139,7 @@
27
28 delegate: ListItem.Standard {
29 Label {
30- text: searchCityModel.status == XmlListModel.Ready ? city + ", " + country : i18n.tr("Loading...");
31+ text: searchCityModel.status == XmlListModel.Ready ? city + ", " + country : i18n.tr("Loading");
32 anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
33 fontSize: "large"
34 }
35
36=== modified file 'po/ubuntu-clock-app.pot'
37--- po/ubuntu-clock-app.pot 2013-07-07 19:24:47 +0000
38+++ po/ubuntu-clock-app.pot 2013-07-08 17:43:26 +0000
39@@ -8,7 +8,7 @@
40 msgstr ""
41 "Project-Id-Version: ubuntu-clock-app\n"
42 "Report-Msgid-Bugs-To: \n"
43-"POT-Creation-Date: 2013-07-07 21:18+0200\n"
44+"POT-Creation-Date: 2013-07-08 19:24+0200\n"
45 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
46 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
47 "Language-Team: LANGUAGE <LL@li.org>\n"
48@@ -17,20 +17,24 @@
49 "Content-Type: text/plain; charset=CHARSET\n"
50 "Content-Transfer-Encoding: 8bit\n"
51
52-#: ../common/SwipeDelete.qml:44
53-#: ../common/SwipeDelete.qml:50
54-#: ../timer/TimerPage.qml:304
55-#: ../alarm/BackgroundAlarm.qml:45
56-msgid "Delete"
57-msgstr ""
58-
59-#: ../clock/WorldClock.qml:79
60-#: ../clock/WorldClock.qml:101
61-msgid "Search"
62-msgstr ""
63-
64-#: ../clock/WorldClock.qml:142
65-msgid "Loading..."
66+#: ../stopwatch/StopwatchPage.qml:124
67+msgid "Reset"
68+msgstr ""
69+
70+#: ../stopwatch/StopwatchPage.qml:142
71+msgid "Lap"
72+msgstr ""
73+
74+#: ../stopwatch/StopwatchPage.qml:165
75+msgid "Laps"
76+msgstr ""
77+
78+#: ../stopwatch/StopwatchPage.qml:173
79+msgid "Current"
80+msgstr ""
81+
82+#: ../stopwatch/StopwatchPage.qml:187
83+msgid "Recorded laps"
84 msgstr ""
85
86 #: ../clock/EasterEgg.qml:92
87@@ -39,13 +43,42 @@
88
89 #: ../clock/EasterEgg.qml:100
90 #: ../clock/EasterEgg.qml:117
91-msgid "loading"
92+#: ../clock/WorldClock.qml:142
93+msgid "Loading"
94 msgstr ""
95
96 #: ../clock/EasterEgg.qml:126
97 msgid "Sunset"
98 msgstr ""
99
100+#: ../ubuntu-clock-app.qml:112
101+msgid "Clock"
102+msgstr ""
103+
104+#: ../ubuntu-clock-app.qml:124
105+msgid "Alarm"
106+msgstr ""
107+
108+#: ../ubuntu-clock-app.qml:140
109+msgid "Timer"
110+msgstr ""
111+
112+#: ../ubuntu-clock-app.qml:150
113+msgid "Stopwatch"
114+msgstr ""
115+
116+#: ../alarm/BackgroundAlarm.qml:45
117+#: ../timer/TimerPage.qml:304
118+#: ../common/SwipeDelete.qml:44
119+#: ../common/SwipeDelete.qml:50
120+msgid "Delete"
121+msgstr ""
122+
123+#: ../alarm/BackgroundAlarm.qml:51
124+#: ../alarm/AlarmPage.qml:765
125+msgid "Edit"
126+msgstr ""
127+
128 #: ../clock/ClockPage.qml:158
129 msgid "Current Location"
130 msgstr ""
131@@ -79,29 +112,9 @@
132 msgid "Add Preset"
133 msgstr ""
134
135-#: ../stopwatch/StopwatchPage.qml:124
136-msgid "Reset"
137-msgstr ""
138-
139-#: ../stopwatch/StopwatchPage.qml:142
140-msgid "Lap"
141-msgstr ""
142-
143-#: ../stopwatch/StopwatchPage.qml:165
144-msgid "Laps"
145-msgstr ""
146-
147-#: ../stopwatch/StopwatchPage.qml:173
148-msgid "Current"
149-msgstr ""
150-
151-#: ../stopwatch/StopwatchPage.qml:187
152-msgid "Recorded laps"
153-msgstr ""
154-
155-#: ../alarm/BackgroundAlarm.qml:51
156-#: ../alarm/AlarmPage.qml:765
157-msgid "Edit"
158+#: ../clock/WorldClock.qml:79
159+#: ../clock/WorldClock.qml:101
160+msgid "Search"
161 msgstr ""
162
163 #: ../alarm/AlarmPage.qml:440
164@@ -159,15 +172,3 @@
165 #: ../alarm/AlarmPage.qml:747
166 msgid "Add Alarm"
167 msgstr ""
168-
169-#: ../ubuntu-clock-app.qml:112
170-msgid "Clock"
171-msgstr ""
172-
173-#: ../ubuntu-clock-app.qml:134
174-msgid "Timer"
175-msgstr ""
176-
177-#: ../ubuntu-clock-app.qml:144
178-msgid "Stopwatch"
179-msgstr ""

Subscribers

People subscribed via source and target branches