Merge lp:~nik90/ubuntu-clock-app/fix-autopilot-environment-cleanup into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 331
Merged at revision: 333
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-autopilot-environment-cleanup
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 20 lines (+2/-2)
1 file modified
tests/autopilot/ubuntu_clock_app/tests/__init__.py (+2/-2)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-autopilot-environment-cleanup
Reviewer Review Type Date Requested Status
Leo Arias (community) code review Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs Pending
Review via email: mp+205503@code.launchpad.net

Commit message

Updated autopilot sqlite_dir location in light of the recent transition to u1db for local storage.

Description of the change

The clock app has transitioned to u1db for local storage. This has resulted in the sqlite_dir to be changed from .local/share/com.ubuntu.clock/Databases to .local/share/com.ubuntu.clock/. This MP fixes autopilot to use the new path.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

nik90: your branch seems ok to fix the current tests.
but renato is right, it would be better to use a different path for the tests.
if you can modify the database path to a temporary using environment variables, that would be ideal.

review: Approve (code review)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

@balloons, do note that after discussing this with elopio on IRC, it was decided that the database path approach (using python fissures) would be implemented next week either by you guys or myself depending on who gets to it first. Until then I would rather not want this MP to be delayed since I have lots of MP coming this week where jenkins autopilot will incorrectly set up the environment causing flaky test.

This is an important prerequisite MP for other MPs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_clock_app/tests/__init__.py'
2--- tests/autopilot/ubuntu_clock_app/tests/__init__.py 2013-11-04 20:40:16 +0000
3+++ tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-02-09 17:03:58 +0000
4@@ -1,6 +1,6 @@
5 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
6 #
7-# Copyright (C) 2013 Canonical Ltd
8+# Copyright (C) 2013, 2014 Canonical Ltd
9 #
10 # This program is free software: you can redistribute it and/or modify
11 # it under the terms of the GNU General Public License version 3 as
12@@ -45,7 +45,7 @@
13 local_location = "../../ubuntu-clock-app.qml"
14 installed_location = "/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml"
15 sqlite_dir = os.path.expanduser(
16- "~/.local/share/com.ubuntu.clock/Databases")
17+ "~/.local/share/com.ubuntu.clock")
18 backup_dir = sqlite_dir + ".backup"
19
20 def setUp(self):

Subscribers

People subscribed via source and target branches