Code review comment for lp:~nik90/ubuntu-clock-app/fix-alarm-tests
Revision history for this message
| Nekhelesh Ramananthan (nik90) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Thanks for your review Nicholas. I am happy that you like the changes to the emulator functions in terms of naming and other subtle changes.
>
> Can you explain what this temp fix is, etc? bug number?
> containerHeight: itemHeight * 7 // Temporary fix for autopilot
>
Fixed in rev 351. I have added a detailed comment there explaining why that fix is needed for the AP tests.
>
> Probably should try and be consistent on all of your docstrings, add them for
> all the emulator functions.
>
In this MP I want to only modify/improve the alarm tests. I do not want to change other parts of the tests. As a result, looking at the test_alarm.py and the alarm emulator functions, all of them have a docstring explaining what they. I added better docstrings for the alarm tests in rev 352.
> Your ' and " are still inconsistent, since elopio mentioned it :-) My
> preference is probably different than his; strings are ", literal strings are
> '.
As far as the alarms AP is concerned, I have made all of the consistently to using single quotes. There are inconsistencies in stopwatch, timer and clock tests. But I rather address in another MP than this one.