Merge lp:~nik90/ubuntu-clock-app/fix-1440732 into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Riccardo Padovani
Approved revision: 243
Merged at revision: 242
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-1440732
Merge into: lp:ubuntu-clock-app
Diff against target: 86 lines (+12/-7)
3 files modified
app/worldclock/UserWorldCityDelegate.qml (+4/-0)
debian/changelog (+1/-0)
po/com.ubuntu.clock.pot (+7/-7)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-1440732
Reviewer Review Type Date Requested Status
Riccardo Padovani Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+255260@code.launchpad.net

Commit message

Fixes the timezone difference label overflowing into the clock.

Description of the change

Fixes the timezone difference label overflowing into the clock.

To test, try opening the clock in german (by setting phone language).

Before: https://launchpadlibrarian.net/202260067/screenshot20155606_145613225%5B1%5D.png
After: https://imgur.com/GnQSOtq

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Tested, works like a charm, good fix!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/worldclock/UserWorldCityDelegate.qml'
2--- app/worldclock/UserWorldCityDelegate.qml 2014-09-10 18:52:50 +0000
3+++ app/worldclock/UserWorldCityDelegate.qml 2015-04-06 13:37:20 +0000
4@@ -129,10 +129,14 @@
5 id: relativeTimeLabel
6 objectName: "relativeTimeLabel" + index
7
8+ anchors.left: localTimeVisual.right
9 anchors.right: parent.right
10 anchors.verticalCenter: parent.verticalCenter
11
12 fontSize: "xx-small"
13+ wrapMode: Text.WordWrap
14+ maximumLineCount: 2
15+ elide: Text.ElideRight
16 horizontalAlignment: Text.AlignRight
17 text: {
18 var day;
19
20=== modified file 'debian/changelog'
21--- debian/changelog 2015-03-17 22:35:16 +0000
22+++ debian/changelog 2015-04-06 13:37:20 +0000
23@@ -14,6 +14,7 @@
24 * Fixed strings not following gettext-style plural forms. (LP: #1431446)
25 * Renabled create alarm tests on device which were disabled due to upstream bug
26 in autopilot. (LP: #1426108)
27+ * Fixed timezone difference label overflowing into the clock (LP: #1440732)
28
29 [Brendan Donegan]
30 * Fixed AP failure by waiting for the bottom edge tip visible property to be true
31
32=== modified file 'po/com.ubuntu.clock.pot'
33--- po/com.ubuntu.clock.pot 2015-03-31 19:03:09 +0000
34+++ po/com.ubuntu.clock.pot 2015-04-06 13:37:20 +0000
35@@ -8,7 +8,7 @@
36 msgstr ""
37 "Project-Id-Version: \n"
38 "Report-Msgid-Bugs-To: \n"
39-"POT-Creation-Date: 2015-03-31 20:29+0200\n"
40+"POT-Creation-Date: 2015-04-06 15:32+0200\n"
41 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
42 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
43 "Language-Team: LANGUAGE <LL@li.org>\n"
44@@ -176,37 +176,37 @@
45
46 #. TRANSLATORS: this indicates if the time in a world clock
47 #. is behind or ahead of the time at the current location
48-#: ../app/worldclock/UserWorldCityDelegate.qml:142
49+#: ../app/worldclock/UserWorldCityDelegate.qml:146
50 msgid "behind"
51 msgstr ""
52
53-#: ../app/worldclock/UserWorldCityDelegate.qml:143
54+#: ../app/worldclock/UserWorldCityDelegate.qml:147
55 msgid "ahead"
56 msgstr ""
57
58 #. TRANSLATORS: the first argument is hour, followed by
59 #. minute, and the translation for either 'behind' or
60 #. 'ahead'
61-#: ../app/worldclock/UserWorldCityDelegate.qml:153
62+#: ../app/worldclock/UserWorldCityDelegate.qml:157
63 #, qt-format
64 msgid "%1h %2m %3"
65 msgstr ""
66
67 #. TRANSLATORS: the first argument is hour, followed by the
68 #. translation for either 'behind' or 'ahead'
69-#: ../app/worldclock/UserWorldCityDelegate.qml:162
70+#: ../app/worldclock/UserWorldCityDelegate.qml:166
71 #, qt-format
72 msgid "%1h %2"
73 msgstr ""
74
75 #. TRANSLATORS: the first argument is minute, followed by the
76 #. translation for either 'behind' or 'ahead'
77-#: ../app/worldclock/UserWorldCityDelegate.qml:170
78+#: ../app/worldclock/UserWorldCityDelegate.qml:174
79 #, qt-format
80 msgid "%1m %2"
81 msgstr ""
82
83-#: ../app/worldclock/UserWorldCityDelegate.qml:176
84+#: ../app/worldclock/UserWorldCityDelegate.qml:180
85 msgid "Same time"
86 msgstr ""
87

Subscribers

People subscribed via source and target branches