Merge lp:~nik90/ubuntu-clock-app/fix-1215334 into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Francis Ginther
Approved revision: 180
Merged at revision: 180
Proposed branch: lp:~nik90/ubuntu-clock-app/fix-1215334
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 41 lines (+4/-5)
1 file modified
clock/ClockPage.qml (+4/-5)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/fix-1215334
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michal Izydorczyk design Pending
Ubuntu Clock Developers Pending
Review via email: mp+183764@code.launchpad.net

Commit message

Increases the digital clock font size to units.dp(41) as per design spec. Fixes bug 1215334.

Description of the change

Increases the digital clock font size to units.dp(41) as per design spec. Fixes bug 1215334.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

@Michal, please confirm if this meets the design specs.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

generic-mediumtests failed due admin error. retrying.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clock/ClockPage.qml'
2--- clock/ClockPage.qml 2013-09-02 17:06:34 +0000
3+++ clock/ClockPage.qml 2013-09-03 21:13:27 +0000
4@@ -33,7 +33,7 @@
5 // Property to hold the formatted time string to show on the screen
6 property string currentTimeFormatted
7 property real currentTimeStamp
8- property real diff: new Date().getTimezoneOffset()
9+ property real diff: new Date().getTimezoneOffset()
10
11 Component.onCompleted: {
12 Utils.log("ClockPage loaded");
13@@ -80,9 +80,8 @@
14 anchors.centerIn: parent
15 horizontalAlignment: Text.AlignHCenter
16 verticalAlignment: Text.AlignVCenter
17- fontSize: "x-large"
18 color: Theme.palette.normal.baseText
19-
20+ font.pixelSize: units.dp(41)
21 text: currentTimeFormatted
22 }
23 }
24@@ -91,7 +90,7 @@
25 AnalogClockFace {
26 id: clockFace
27
28- anchors { top: parent.top; topMargin: units.gu(9); horizontalCenter: parent.horizontalCenter }
29+ anchors { top: parent.top; topMargin: units.gu(9); horizontalCenter: parent.horizontalCenter }
30
31 onClicked: {
32 if (easterEggCircle.isReady == XmlListModel.Ready) {
33@@ -185,7 +184,7 @@
34 fontSize: "large"
35 }
36
37- Label {
38+ Label {
39 text: Qt.formatTime(new Date(currentTimeStamp + (rawOffSet * 60000)), "hh:mm A")
40 anchors { verticalCenter: parent.verticalCenter; right: parent.right; rightMargin: units.gu(2) }
41 color: Theme.palette.normal.baseText

Subscribers

People subscribed via source and target branches