Merge lp:~nik90/ubuntu-clock-app/enable-alarms-automatically into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 114
Merged at revision: 116
Proposed branch: lp:~nik90/ubuntu-clock-app/enable-alarms-automatically
Merge into: lp:ubuntu-clock-app
Diff against target: 24 lines (+2/-1)
2 files modified
app/alarm/EditAlarmPage.qml (+1/-1)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/enable-alarms-automatically
Reviewer Review Type Date Requested Status
Mihir Soni (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+235404@code.launchpad.net

Commit message

Enable alarms automatically after a user updates it.

Description of the change

Enable alarms automatically after a user updates it.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
114. By Nekhelesh Ramananthan

merged with trunk

Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/EditAlarmPage.qml'
2--- app/alarm/EditAlarmPage.qml 2014-09-16 17:00:11 +0000
3+++ app/alarm/EditAlarmPage.qml 2014-09-24 11:50:41 +0000
4@@ -111,7 +111,7 @@
5 tempAlarm.message = _alarm.message
6 tempAlarm.date = alarmTime
7 tempAlarm.type = _alarm.type
8- tempAlarm.enabled = _alarm.enabled
9+ tempAlarm.enabled = true
10 tempAlarm.sound = _alarm.sound
11 tempAlarm.daysOfWeek = _alarm.daysOfWeek
12
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2014-09-21 13:22:35 +0000
16+++ debian/changelog 2014-09-24 11:50:41 +0000
17@@ -33,6 +33,7 @@
18 * Added alarm snooze settings (LP: #1354400)
19 * Fixed default alarm label not being translatable (LP: #1365012)
20 * Improved multiselect mode behavior and appearance (LP: #1370146)
21+ * Enabled alarms automatically after updating it (LP: #1372090)
22 * Automatically focus textfield (LP: #1372089)
23
24 [Zsombor Egri]

Subscribers

People subscribed via source and target branches