Merge lp:~nik90/ubuntu-clock-app/dynamic-positioning-part1 into lp:ubuntu-clock-app/saucy
Proposed by
Nekhelesh Ramananthan
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Nekhelesh Ramananthan | ||||||||
Approved revision: | 209 | ||||||||
Merged at revision: | 200 | ||||||||
Proposed branch: | lp:~nik90/ubuntu-clock-app/dynamic-positioning-part1 | ||||||||
Merge into: | lp:ubuntu-clock-app/saucy | ||||||||
Diff against target: |
403 lines (+79/-101) 6 files modified
clock/ClockPage.qml (+14/-8) common/AnimationContainer.qml (+0/-50) stopwatch/StopwatchPage.qml (+13/-7) tests/autopilot/ubuntu_clock_app/tests/test_timer.py (+2/-2) timer/TimerPage.qml (+50/-28) ubuntu-clock-app.qml (+0/-6) |
||||||||
To merge this branch: | bzr merge lp:~nik90/ubuntu-clock-app/dynamic-positioning-part1 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Paolo Rotolo (community) | Approve | ||
Review via email:
|
Commit message
Replaces static positioning of components with Dynamic positioning to allow for different screen size variation.
Description of the change
This MP removes some of the hardcoded positioning of certain components. Static positioning of components results in components hidden or not appearing as expecting. It replaces AnimationContainer with just ordinary flickables which are supported well by the SDK.
To post a comment you must log in.
FAILED: Continuous integration, rev:207 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/32/ 91.189. 93.70:8080/ job/generic- mediumtests/ 426 91.189. 93.70:8080/ job/ubuntu- clock-app- precise- amd64-ci/ 32 91.189. 93.70:8080/ job/ubuntu- clock-app- quantal- amd64-ci/ 32 91.189. 93.70:8080/ job/ubuntu- clock-app- raring- amd64-ci/ 32 91.189. 93.70:8080/ job/ubuntu- clock-app- saucy-amd64- ci/32
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- clock-app- ci/32/rebuild
http://