Code review comment for lp:~nik90/ubuntu-clock-app/dialer-transition

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> 18 + // The range of the analogue clock is 0-60 while the alarm hours
> should be between 00-23. Hence the factor 23/60
> 19 + alarmTime.setHours(Math.round(addAlarmFace.hours*23/60),
> Math.round(addAlarmFace.minutes), 0)
>
> Could it make sense to create a function hoursToCirclePosition() instead of
> copy pasting this all over the place?
>

Fixed in rev 300

« Back to merge proposal