Merge lp:~nik90/ubuntu-clock-app/clock-fontsizes into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 110
Merged at revision: 110
Proposed branch: lp:~nik90/ubuntu-clock-app/clock-fontsizes
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 191 lines (+53/-21)
4 files modified
clock/ClockPage.qml (+37/-12)
clock/EasterEgg.qml (+4/-4)
clock/WorldClock.qml (+11/-3)
common/SwipeDelete.qml (+1/-2)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/clock-fontsizes
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+170869@code.launchpad.net

Commit message

Tweak clock font sizes accorded to updated designs

Description of the change

Tweak clock font sizes accorded to updated designs

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clock/ClockPage.qml'
2--- clock/ClockPage.qml 2013-06-15 20:15:44 +0000
3+++ clock/ClockPage.qml 2013-06-21 16:15:32 +0000
4@@ -67,7 +67,7 @@
5 Component.onCompleted: {
6 _loadDB();
7 diff = worldModel.timeDiff;
8- currentLocation.text = worldModel.city;
9+ currentLocationCity.text = worldModel.city;
10 currentTimeFormatted = Qt.formatTime(new Date(currentTimeStamp + (diff * 60000)), "hh:mm")
11 }
12 }
13@@ -107,7 +107,7 @@
14 AnalogClockFace {
15 id: clockFace
16
17- anchors { top: parent.top; topMargin: units.gu(17); horizontalCenter: parent.horizontalCenter }
18+ anchors { top: parent.top; topMargin: units.gu(9); horizontalCenter: parent.horizontalCenter }
19 Component.onCompleted: easterEggCircle.reloadSunRiseModel()
20
21 onClicked: {
22@@ -146,33 +146,58 @@
23 id: savedWorldClock
24
25 height: childrenRect.height;
26- anchors { left:parent.left; right:parent.right; top: clockFace.bottom; topMargin: units.gu(12)}
27+ anchors { left:parent.left; right:parent.right; top: clockFace.bottom; topMargin: units.gu(13)}
28
29 ListItem.ThinDivider {}
30
31- ListItem.Header { text: i18n.tr("Current Location") }
32+ ListItem.Header {
33+ Label {
34+ text: i18n.tr("Current Location")
35+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(2) }
36+ fontSize: "medium"
37+ }
38+ }
39
40- ListItem.SingleValue {
41+ ListItem.Standard {
42 id: currentLocation
43- text: "UTC"
44- value: Qt.formatTime(new Date(currentTimeStamp + (diff * 60000)), "hh:mm A");
45+ Label {
46+ id: currentLocationCity
47+ text: i18n.tr("UTC")
48+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
49+ fontSize: "large"
50+ }
51+ Label {
52+ text: Qt.formatTime(new Date(currentTimeStamp + (diff * 60000)), "hh:mm A");
53+ anchors { verticalCenter: parent.verticalCenter; right: parent.right; rightMargin: units.gu(2) }
54+ fontSize: "large"
55+ }
56 }
57
58- ListItem.Header { text: i18n.tr("World") }
59+ ListItem.Header {
60+ Label {
61+ text: i18n.tr("World")
62+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(2) }
63+ fontSize: "medium"
64+ }
65+ }
66
67 ListView {
68 id: listWorldClocks
69
70 anchors { left: parent.left; right: parent.right }
71- height: units.gu(30)
72+ height: units.gu(21)
73 model: worldModel
74 currentIndex: -1
75
76 delegate: ListItem.Standard {
77- text: cityName;
78+ Label {
79+ text: cityName;
80+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
81+ fontSize: "large"
82+ }
83
84 Label {
85- fontSize: "medium"
86+ fontSize: "large"
87 text: Qt.formatTime(new Date(currentTimeStamp + (rawOffSet * 60000)), "hh:mm A");
88 anchors { verticalCenter: parent.verticalCenter; right: parent.right; rightMargin: units.gu(2) }
89 }
90@@ -191,7 +216,7 @@
91 }
92
93 onClicked: {
94- currentLocation.text = cityName;
95+ currentLocationCity.text = cityName;
96 diff = rawOffSet;
97 worldModel.appendCurrentLocation(cityName, diff);
98 }
99
100=== modified file 'clock/EasterEgg.qml'
101--- clock/EasterEgg.qml 2013-06-10 14:14:12 +0000
102+++ clock/EasterEgg.qml 2013-06-21 16:15:32 +0000
103@@ -81,7 +81,7 @@
104 id: sunriseLabel
105 anchors.horizontalCenter: parent.horizontalCenter
106 color: Constants.brightWhite;
107- fontSize: "small";
108+ fontSize: "medium";
109 text: i18n.tr("Sunrise")
110 }
111
112@@ -89,7 +89,7 @@
113 id: sunriseTimeLabel
114 anchors.horizontalCenter: parent.horizontalCenter
115 color: Constants.brightWhite;
116- font.pixelSize: 35;
117+ fontSize: "x-large";
118 text: i18n.tr("loading")
119 }
120
121@@ -106,7 +106,7 @@
122 width: parent.width
123 horizontalAlignment: Text.AlignHCenter
124 color: Constants.brightWhite;
125- font.pixelSize: 35;
126+ fontSize: "x-large";
127 text: i18n.tr("loading")
128 }
129
130@@ -115,7 +115,7 @@
131 width: parent.width
132 horizontalAlignment: Text.AlignHCenter
133 color: Constants.brightWhite;
134- fontSize: "small";
135+ fontSize: "medium";
136 text: i18n.tr("Sunset")
137 }
138
139
140=== modified file 'clock/WorldClock.qml'
141--- clock/WorldClock.qml 2013-06-15 22:46:44 +0000
142+++ clock/WorldClock.qml 2013-06-21 16:15:32 +0000
143@@ -12,7 +12,7 @@
144 property string city: "null";
145 property real lng: 0;
146 property real lat: 0;
147- property real rawOffSet: 0;
148+ property real rawOffSet: 0;
149
150 // Property to store the city searched by the user
151 property string search_string: "null";
152@@ -124,7 +124,11 @@
153 Component {
154 id: sectionHeading
155 ListItem.Header {
156- text: section
157+ Label {
158+ text: section
159+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(2) }
160+ fontSize: "medium"
161+ }
162 }
163 }
164
165@@ -134,7 +138,11 @@
166 section.labelPositioning: ViewSection.InlineLabels
167
168 delegate: ListItem.Standard {
169- text: searchCityModel.status == XmlListModel.Ready ? searchCityModel.get(index).city + ", " + searchCityModel.get(index).country : i18n.tr("Loading...");
170+ Label {
171+ text: searchCityModel.status == XmlListModel.Ready ? searchCityModel.get(index).city + ", " + searchCityModel.get(index).country : i18n.tr("Loading...");
172+ anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
173+ fontSize: "large"
174+ }
175 selected: worldList.currentIndex == index;
176
177 onClicked: {
178
179=== modified file 'common/SwipeDelete.qml'
180--- common/SwipeDelete.qml 2013-06-15 14:21:07 +0000
181+++ common/SwipeDelete.qml 2013-06-21 16:15:32 +0000
182@@ -34,8 +34,7 @@
183 anchors.fill: parent
184 verticalAlignment: Text.AlignVCenter
185 color: Constants.brightWhite
186- fontSize: "medium"
187- font.bold: true
188+ fontSize: "large"
189 }
190
191 states: [

Subscribers

People subscribed via source and target branches