Merge lp:~nik90/ubuntu-clock-app/change-x-icon into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 102
Merged at revision: 102
Proposed branch: lp:~nik90/ubuntu-clock-app/change-x-icon
Merge into: lp:ubuntu-clock-app
Diff against target: 40 lines (+10/-19)
1 file modified
app/alarm/EditAlarmPage.qml (+10/-19)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/change-x-icon
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Mihir Soni (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+234850@code.launchpad.net

Commit message

Replace custom back icon X with the general "<" chevron back button as requested by design.

Description of the change

Replace custom back icon X with the general "<" chevron back button as requested by design.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks great.
Thanks for MR.

review: Approve
Revision history for this message
Mihir Soni (mihirsoni) wrote :

lgtm !!

Thanks for MR.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/EditAlarmPage.qml'
2--- app/alarm/EditAlarmPage.qml 2014-09-08 22:31:11 +0000
3+++ app/alarm/EditAlarmPage.qml 2014-09-16 17:03:08 +0000
4@@ -40,26 +40,17 @@
5 title: isNewAlarm ? i18n.tr("New alarm") : i18n.tr("Edit alarm")
6 visible: false
7
8- head {
9- backAction: Action {
10- iconName: "close"
11- onTriggered: {
12- mainStack.pop()
13+ head.actions: Action {
14+ id: saveAlarmButton
15+ iconName: "ok"
16+ objectName: "saveAlarmAction"
17+ text: i18n.tr("Alarm")
18+ onTriggered: {
19+ if(isNewAlarm) {
20+ saveNewAlarm()
21 }
22- }
23-
24- actions: Action {
25- id: saveAlarmButton
26- iconName: "ok"
27- objectName: "saveAlarmAction"
28- text: i18n.tr("Alarm")
29- onTriggered: {
30- if(isNewAlarm) {
31- saveNewAlarm()
32- }
33- else {
34- updateAlarm()
35- }
36+ else {
37+ updateAlarm()
38 }
39 }
40 }

Subscribers

People subscribed via source and target branches