Merge lp:~nik90/ubuntu-clock-app/add-stopwatch-lap-animation into lp:ubuntu-clock-app/saucy

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 381
Merged at revision: 382
Proposed branch: lp:~nik90/ubuntu-clock-app/add-stopwatch-lap-animation
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 36 lines (+12/-1)
2 files modified
stopwatch/LapList.qml (+1/-0)
stopwatch/StopwatchPage.qml (+11/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/add-stopwatch-lap-animation
Reviewer Review Type Date Requested Status
Paolo Rotolo (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Riccardo Padovani Pending
Review via email: mp+212889@code.launchpad.net

Commit message

Adds a subtle animation to the stopwatch lap list which now slides from the bottom when a new lap is added by the user.

Description of the change

Adds a subtle animation to the stopwatch lap list which now slides from the bottom when a new lap is added by the user.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paolo Rotolo (paolorotolo) wrote :

Looks good to me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stopwatch/LapList.qml'
2--- stopwatch/LapList.qml 2014-02-26 20:27:13 +0000
3+++ stopwatch/LapList.qml 2014-03-26 16:41:22 +0000
4@@ -37,6 +37,7 @@
5 property int maxItemsVisible
6
7 height: childrenRect.height
8+ visible: lapModel.count !== 0
9
10 ListItem.ThinDivider { id: divider}
11
12
13=== modified file 'stopwatch/StopwatchPage.qml'
14--- stopwatch/StopwatchPage.qml 2014-02-20 23:34:53 +0000
15+++ stopwatch/StopwatchPage.qml 2014-03-26 16:41:22 +0000
16@@ -294,9 +294,19 @@
17 lapModel: laps
18 width: parent.width
19 height: childrenRect.height
20- anchors.top: stopwatchFacePhoneLayoutContainer.bottom
21+ anchors.top: parent.bottom
22 maxItemsVisible: !wideAspect ? 5 : parseInt((stopwatchPage.height - headerHeight)/units.gu(6))
23
24+ states: State {
25+ name: "newlap"
26+ when: laps.count !== 0 && !wideAspect
27+ AnchorChanges { target: listLap; anchors.top: stopwatchFacePhoneLayoutContainer.bottom }
28+ }
29+
30+ transitions: Transition {
31+ AnchorAnimation { duration: UbuntuAnimation.BriskDuration; easing: UbuntuAnimation.StandardEasing }
32+ }
33+
34 }
35 }
36 }

Subscribers

People subscribed via source and target branches