Ubuntu Clock App

Merge lp:~nik90/ubuntu-clock-app/add-stopwatch-keyword into lp:ubuntu-clock-app

  1. add-stopwatch-keyword
  2. Merge into trunk
Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 344
Merged at revision: 343
Proposed branch: lp:~nik90/ubuntu-clock-app/add-stopwatch-keyword
Merge into: lp:ubuntu-clock-app
Diff against target: 24 lines (+2/-1)
2 files modified
debian/changelog (+1/-0)
ubuntu-clock-app.desktop.in.in (+1/-1)
To merge this branch: bzr merge lp:~nik90/ubuntu-clock-app/add-stopwatch-keyword
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Review via email: mp+268733@code.launchpad.net

Commit message

Added stopwatch keyword to the desktop

Description of the change

Added stopwatch keyword to the desktop

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

* Does the MP add/remove user visible strings? If Yes, has the pot file been
    updated?

Yes, pot file has been updated.

* Does the MP change the UI? If Yes, has it been approved by design?

Nope

* Did you perform an exploratory manual test run of your code change and any
    related functionality?

Yes

* If the MP fixes a bug or implements a feature, are there accompanying unit
    and autopilot tests?

Nope

* Is the clock app trunk buildable and runnable using Qtcreator?

Yes

* Was the debian changelog updated?

Yes

* Was the copyright years updated if necessary?

Yes

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM. We should update the store metadata when this is uploaded too.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:344
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/786/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-ci/131

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/786/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-08-20 21:15:00 +0000
3+++ debian/changelog 2015-08-21 11:03:34 +0000
4@@ -12,6 +12,7 @@
5 [Nekhelesh Ramananthan]
6 * Increase the height of times in the alarm screen (LP: #1365428)
7 * Implement Stopwatch feature (LP: 1437313)
8+ * Added stopwatch keyword to the desktop file
9 * Fixed the confusing behavior of the confirmation button (LP: #1408015)
10 * Added README.mergeproposal checklist to help with the review process.
11 * Fix alarm interval information being inconsistent (LP: #1466000)
12
13=== modified file 'ubuntu-clock-app.desktop.in.in'
14--- ubuntu-clock-app.desktop.in.in 2015-06-16 07:18:47 +0000
15+++ ubuntu-clock-app.desktop.in.in 2015-08-21 11:03:34 +0000
16@@ -2,7 +2,7 @@
17 Version=1.0
18 _Name=Clock
19 _Comment=A sophisticated clock app that provides world clock and alarm functionality.
20-_Keywords=time;alarm;alert;clock;world;
21+_Keywords=time;alarm;alert;clock;world;stopwatch;
22 Exec=@EXEC@
23 Icon=@ICON@
24 Terminal=false

Subscribers

People subscribed via source and target branches