Merge lp:~nik90/ubuntu-calendar-app/replace-x-icon into lp:ubuntu-calendar-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 453
Merged at revision: 452
Proposed branch: lp:~nik90/ubuntu-calendar-app/replace-x-icon
Merge into: lp:ubuntu-calendar-app
Diff against target: 31 lines (+6/-15)
1 file modified
NewEvent.qml (+6/-15)
To merge this branch: bzr merge lp:~nik90/ubuntu-calendar-app/replace-x-icon
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+234851@code.launchpad.net

Commit message

Replaces the "X" icon in the NewEvent page with the standard "<" icon as requested by design for clock app.

Description of the change

This MP replaces the "X" icon in the NewEvent page with the standard "<" icon as requested by design for clock app. However this should also apply for the calendar app. hence proposing it here.

To post a comment you must log in.
453. By Nekhelesh Ramananthan

Small code refactor

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me.
Thanks tested and working as expected.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NewEvent.qml'
2--- NewEvent.qml 2014-09-16 14:13:17 +0000
3+++ NewEvent.qml 2014-09-16 17:14:22 +0000
4@@ -53,21 +53,12 @@
5 endTimeInput.text = Qt.formatTime(endDate);
6 }
7
8- head {
9- backAction: Action {
10- iconName: "close"
11- onTriggered: pageStack.pop();
12- }
13-
14- actions: [
15- Action {
16- iconName: "ok"
17- objectName: "save"
18- text: i18n.tr("Save")
19- enabled: !!titleEdit.text.trim()
20- onTriggered: saveToQtPim();
21- }
22- ]
23+ head.actions: Action {
24+ iconName: "ok"
25+ objectName: "save"
26+ text: i18n.tr("Save")
27+ enabled: !!titleEdit.text.trim()
28+ onTriggered: saveToQtPim();
29 }
30
31 Component.onCompleted: {

Subscribers

People subscribed via source and target branches

to status/vote changes: