Merge lp:~nik90/ubuntu-calendar-app/remove-qmlproject-hacks into lp:ubuntu-calendar-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 439
Merged at revision: 440
Proposed branch: lp:~nik90/ubuntu-calendar-app/remove-qmlproject-hacks
Merge into: lp:ubuntu-calendar-app
Diff against target: 50 lines (+0/-41)
2 files modified
calendar-app.qmlproject (+0/-31)
com.ubuntu.calendar.desktop (+0/-10)
To merge this branch: bzr merge lp:~nik90/ubuntu-calendar-app/remove-qmlproject-hacks
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Benjamin Zeller (community) Approve
Ubuntu Calendar Developers Pending
Review via email: mp+233831@code.launchpad.net

Commit message

Removed .qmlproject file and also the desktop file hack. Developers should now open the CMakeList.txt file for development in Qtcreator instead of the .qmlproject file.

Description of the change

With zbenjamin's cmake fixes, calendar app is now ready to remove .qmlproject and also the desktop file hack we had in place. I have removed them and confirmed to test it running on emulator, desktop and phone.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

From now on, everyone should just open the cmakelist.txt file in their qtcreator for development.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

Ok

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'calendar-app.qmlproject'
2--- calendar-app.qmlproject 2013-09-26 05:49:31 +0000
3+++ calendar-app.qmlproject 1970-01-01 00:00:00 +0000
4@@ -1,31 +0,0 @@
5-/* File generated by Qt Creator, version 2.6.1 */
6-
7-import QmlProject 1.1
8-
9-Project {
10- mainFile: "calendar.qml"
11-
12- /* Include .qml, .js, and image files from current directory and subdirectories */
13- QmlFiles {
14- directory: "."
15- }
16- JavaScriptFiles {
17- directory: "."
18- }
19- ImageFiles {
20- directory: "."
21- }
22- /* Shows the README files in the project view */
23- Files {
24- filter: "README*"
25- }
26- /* Shows the translation files and the .pro file used to generate the .pot template */
27- Files {
28- filter: "*.po*"
29- }
30- Files {
31- filter: "*.pro"
32- }
33- /* List of plugin directories passed to QML runtime */
34- importPaths: [ "." ,"/usr/lib/i386-linux-gnu/qt5/qml/", "/usr/lib/x86_64-linux-gnu/qt5/qml" ]
35-}
36
37=== removed file 'com.ubuntu.calendar.desktop'
38--- com.ubuntu.calendar.desktop 2014-07-02 06:45:58 +0000
39+++ com.ubuntu.calendar.desktop 1970-01-01 00:00:00 +0000
40@@ -1,10 +0,0 @@
41-[Desktop Entry]
42-Version=1.0
43-Type=Application
44-Terminal=false
45-Exec=qmlscene calendar.qml
46-Icon=calendar-app@30.png
47-_Name=Calendar
48-_Comment=A calendar for Ubuntu which syncs with online accounts.
49-_Keywords=calendar;event;day;week;year;appointment;meeting;
50-X-Ubuntu-Touch=true

Subscribers

People subscribed via source and target branches

to status/vote changes: