Merge lp:~nik90/ubuntu-calendar-app/migrate-listitemlayout into lp:ubuntu-calendar-app
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Nekhelesh Ramananthan on 2016-03-01 | ||||
| Approved revision: | 764 | ||||
| Merged at revision: | 761 | ||||
| Proposed branch: | lp:~nik90/ubuntu-calendar-app/migrate-listitemlayout | ||||
| Merge into: | lp:ubuntu-calendar-app | ||||
| Diff against target: |
805 lines (+229/-266) 5 files modified
CalendarChoicePopup.qml (+88/-86) CalendarListButtonDelegate.qml (+0/-51) Settings.qml (+43/-80) calendar.qml (+1/-4) po/com.ubuntu.calendar.pot (+97/-45) |
||||
| To merge this branch: | bzr merge lp:~nik90/ubuntu-calendar-app/migrate-listitemlayout | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jenkins Bot | continuous-integration | Approve on 2016-03-01 | |
| Dan Chapman | 2016-02-26 | Approve on 2016-03-01 | |
|
Review via email:
|
|||
Commit Message
- Changed the app background color to #FFFFFF (as per new design spec)
- Switches the following pages to listitemlayout
- SettingsPage.qml
- CalendarChoiceP
Description of the Change
Switches the following pages to listitemlayout
- SettingsPage.qml
- CalendarChoiceP
- 763. By Nekhelesh Ramananthan on 2016-02-26
-
Removed app background gradient as it is not supported and changed background color to white as requested by design
FAILED: Continuous integration, rev:763
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
| Dan Chapman (dpniel) wrote : | # |
Looking good, just a couple of comments inline :-)
- 764. By Nekhelesh Ramananthan on 2016-03-01
-
Removed square brackets and changed back to ListView
FAILED: Continuous integration, rev:764
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/


FAILED: Continuous integration, rev:762 /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 1074/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/630/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 1074/rebuild
https:/