Merge lp:~nik90/reminders-app/add-debian-click-packaging into lp:reminders-app

[Nekhelesh Ramananthan]

- Added debian and click packaging support.
- Added temporary app icon taken from the project page

This MP adds debian and click packaging support.

[David Planella (dpm)]

Just one thing after a first glance:

12 +#
13 +# Basic early stategy was to create two object (text boxs) with a connect
14 +# button for initial API connection. Simply place the request (service call) in the
15 +# lower text field, and the cloud API places requested call in text box.
16 +#
17 +# 1. Focus is on establishing communication with cloud API
18 +# 2. Create note through API
19 +# 3. Retrieve created note
20 +#

This no longer applies, so it might be worth removing it from the README.txt file or remove the file alltogether.

review: Needs Fixing

[lp:~nik90/reminders-app/add-debian-click-packaging]

4. By Nekhelesh Ramananthan on 2013-11-20

Some fixes to debian packaging

5. By Nekhelesh Ramananthan on 2013-11-20

Fixed README.txt

6. By Nekhelesh Ramananthan on 2013-11-20

removed failing unit test

7. By Nekhelesh Ramananthan on 2013-11-20

Removed unnecessary makefile

8. By Nekhelesh Ramananthan on 2013-11-20

merge from master

9. By Nekhelesh Ramananthan on 2013-11-20

small fix to the debian/rules file

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Awesome stuff.

review: Approve

[David Planella (dpm)]

Builds fine here, but with the following Lintian warnings:

W: reminders-app source: diff-contains-bzr-control-dir .bzr
W: reminders-app source: debhelper-but-no-misc-depends reminders-app-autopilot
W: reminders-app source: missing-field-in-dep5-copyright license (paragraph at line 5)
W: reminders-app source: missing-license-text-in-dep5-copyright gpl-3 (paragraph at line 8)

I'll approve for now to get the packaging and Jenkins going, but we will need to address them after that.

review: Approve

[David Planella (dpm)]

Needed fixes filed as bug 1253459

=== removed file 'Makefile'
--- Makefile	2013-10-23 11:02:37 +0000
+++ Makefile	1970-01-01 00:00:00 +0000
@@ -1,21 +0,0 @@
-# More information: https://wiki.ubuntu.com/Touch/Testing
-#
-# Notes for autopilot tests:
-# -----------------------------------------------------------
-# In order to run autopilot tests:
-# sudo apt-add-repository ppa:autopilot/ppa
-# sudo apt-get update
-# sudo apt-get install python-autopilot autopilot-qt
-#############################################################
-
-all:
-
-autopilot:
-	chmod +x tests/autopilot/run
-	tests/autopilot/run
-
-check:
-	qmltestrunner -input tests/unit
-
-run:
-	/usr/bin/qmlscene $@ reminders-app.qml

=== added file 'README.txt'
--- README.txt	1970-01-01 00:00:00 +0000
+++ README.txt	2013-11-20 22:38:39 +0000
@@ -0,0 +1,8 @@
+# ##############################################
+# Ubuntu Reminders App
+#
+# Simple app that will allow interaction between
+# Ubuntu's API & Evernotes cloud API
+#
+################################################
+

=== added directory 'apparmor'
=== added file 'apparmor/reminders-app.json'
--- apparmor/reminders-app.json	1970-01-01 00:00:00 +0000
+++ apparmor/reminders-app.json	2013-11-20 22:38:39 +0000
@@ -0,0 +1,6 @@
+{
+    "policy_groups": [
+        "networking"
+    ],
+    "policy_version": 1
+}

=== added directory 'debian'
=== added file 'debian/changelog'
--- debian/changelog	1970-01-01 00:00:00 +0000
+++ debian/changelog	2013-11-20 22:38:39 +0000
@@ -0,0 +1,5 @@
+reminders-app (0.1) saucy; urgency=low
+
+  * Initial release
+
+ -- David Planella <[e-mail]>  Wed, 23 Oct 2013 16:04:00 -0500

=== added file 'debian/compat'
--- debian/compat	1970-01-01 00:00:00 +0000
+++ debian/compat	2013-11-20 22:38:39 +0000
@@ -0,0 +1,1 @@
+9

=== added file 'debian/control'
--- debian/control	1970-01-01 00:00:00 +0000
+++ debian/control	2013-11-20 22:38:39 +0000
@@ -0,0 +1,30 @@
+Source: reminders-app
+Priority: extra
+Maintainer: Ubuntu App Cats <[e-mail]>
+Build-Depends: debhelper (>= 9),
+	       gettext,
+               python,
+Standards-Version: 3.9.4
+Section: misc
+Homepage: https://launchpad.net/reminders-app
+Vcs-Bzr: https://code.launchpad.net/~reminders-app-dev/reminders-app/trunk
+
+Package: reminders-app
+Section: misc
+Architecture: all
+Depends: ${misc:Depends},
+         qmlscene,
+         qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
+         qtdeclarative5-localstorage-plugin,
+         qtdeclarative5-qtquick2-plugin
+Description: Reminders application
+ Note taking application powered by Evernote
+
+Package: reminders-app-autopilot
+Architecture: all
+Depends: reminders-app (= ${source:Version}),
+         libautopilot-qt,
+         libqt5test5,
+         ubuntu-ui-toolkit-autopilot,
+Description: Test package for the Reminders app
+ Autopilot tests for the Reminders app package

=== added file 'debian/copyright'
--- debian/copyright	1970-01-01 00:00:00 +0000
+++ debian/copyright	2013-11-20 22:38:39 +0000
@@ -0,0 +1,46 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: reminders-app
+Source: https://launchpad.net/reminders-app
+
+Files: *
+Copyright: 2013 Canonical Ltd.
+
+License: GPL-3
+
+Files: debian/*
+Copyright: 2013 Canonical Ltd.
+License: LGPL-3
+
+License: GPL-3
+ This package is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License.
+ .
+ This package is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the complete text of the GNU General
+ Public License can be found in "/usr/share/common-licenses/GPL-3".
+
+License: LGPL-3
+ This package is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License.
+ .
+ This package is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ Lesser General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the complete text of the GNU Lesser General
+ Public License can be found in "/usr/share/common-licenses/LGPL-3".

=== added file 'debian/reminders-app-autopilot.install'
--- debian/reminders-app-autopilot.install	1970-01-01 00:00:00 +0000
+++ debian/reminders-app-autopilot.install	2013-11-20 22:38:39 +0000
@@ -0,0 +1,1 @@
+tests/autopilot/reminders_app/* usr/lib/python2.7/dist-packages/reminders_app/

=== added file 'debian/reminders-app.install'
--- debian/reminders-app.install	1970-01-01 00:00:00 +0000
+++ debian/reminders-app.install	2013-11-20 22:38:39 +0000
@@ -0,0 +1,6 @@
+reminders-app usr/bin/
+reminders-app.desktop usr/share/applications/
+*.qml usr/share/reminders-app/
+*.png usr/share/reminders-app/
+components usr/share/reminders-app/
+ui usr/share/reminders-app/

=== added file 'debian/rules'
--- debian/rules	1970-01-01 00:00:00 +0000
+++ debian/rules	2013-11-20 22:38:39 +0000
@@ -0,0 +1,21 @@
+#!/usr/bin/make -f
+# -*- makefile -*-
+
+# Uncomment this to turn on verbose mode.
+#export DH_VERBOSE=1
+
+%:
+	dh $@
+
+override_dh_install:	
+	dh_install --fail-missing
+	appname=com.ubuntu.reminders-app; \
+	debname=reminders-app; \
+	for pofile in $(shell find ./po -name "*.po"); do \
+		pofilename="$${pofile##*/}"; \
+		langcode="$${pofilename%.*}"; \
+		localedir="debian/$$debname/usr/share/locale/$$langcode/LC_MESSAGES"; \
+		mkdir -p $$localedir; \
+		mofile="$$localedir/$$appname.mo"; \
+		msgfmt -o $$mofile $$pofile; \
+	done

=== added directory 'debian/source'
=== added file 'debian/source/format'
--- debian/source/format	1970-01-01 00:00:00 +0000
+++ debian/source/format	2013-11-20 22:38:39 +0000
@@ -0,0 +1,1 @@
+1.0

=== added file 'reminders-app'
--- reminders-app	1970-01-01 00:00:00 +0000
+++ reminders-app	2013-11-20 22:38:39 +0000
@@ -0,0 +1,2 @@
+#!/bin/bash
+qmlscene /usr/share/reminders-app/reminders-app.qml

=== modified file 'reminders-app.desktop'
--- reminders-app.desktop	2013-10-23 11:02:37 +0000
+++ reminders-app.desktop	2013-11-20 22:38:39 +0000
@@ -2,7 +2,8 @@
 Name=reminders-app
 Comment=My project description
 Exec=/usr/bin/qmlscene $@ /usr/share/reminders-app/reminders-app.qml
-Icon=qmlscene
+Icon=/usr/share/ubuntu-clock-app/reminders-app.png
 Terminal=false
 Type=Application
 X-Ubuntu-Touch=true
+X-Ubuntu-Gettext-Domain=com.ubuntu.reminders-app

=== added file 'reminders-app.png'
Binary files reminders-app.png	1970-01-01 00:00:00 +0000 and reminders-app.png	2013-11-20 22:38:39 +0000 differ
=== renamed directory 'tests/autopilot/reminders-app' => 'tests/autopilot/reminders_app'
=== removed file 'tests/unit/tst_hellocomponent.qml'
--- tests/unit/tst_hellocomponent.qml	2013-10-23 11:02:37 +0000
+++ tests/unit/tst_hellocomponent.qml	1970-01-01 00:00:00 +0000
@@ -1,49 +0,0 @@
-import QtQuick 2.0
-import QtTest 1.0
-import Ubuntu.Components 0.1
-import "../../components"
-
-// See more details @ http://qt-project.org/doc/qt-5.0/qtquick/qml-testcase.html
-
-// Execute tests with:
-//   qmltestrunner
-
-Item {
-    // The objects
-    HelloComponent {
-        id: objectUnderTest
-    }
-
-    TestCase {
-        name: "HelloComponent"
-
-        function init() {
-            console.debug(">> init");
-            compare("",objectUnderTest.text,"text was not empty on init");
-            console.debug("<< init");
-        }
-
-        function cleanup() {
-            console.debug(">> cleanup");
-            console.debug("<< cleanup");
-        }
-
-        function initTestCase() {
-            console.debug(">> initTestCase");
-            console.debug("<< initTestCase");
-        }
-
-        function cleanupTestCase() {
-            console.debug(">> cleanupTestCase");
-            console.debug("<< cleanupTestCase");
-        }
-
-        function test_canReadAndWriteText() {
-            var expected = "Hello World";
-
-            objectUnderTest.text = expected;
-
-            compare(expected,objectUnderTest.text,"expected did not equal result");
-        }
-    }
-}