Merge lp:~nik90/podbird/fix-textfield-color into lp:podbird
Proposed by
Nekhelesh Ramananthan
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 75 | ||||||||
Proposed branch: | lp:~nik90/podbird/fix-textfield-color | ||||||||
Merge into: | lp:podbird | ||||||||
Diff against target: |
121 lines (+19/-16) 5 files modified
app/Podbird.desktop.in (+1/-1) app/podbird.qml (+3/-0) app/settings/About.qml (+1/-1) app/ui/EpisodesPage.qml (+1/-1) po/com.mikeasoft.podbird.pot (+13/-13) |
||||||||
To merge this branch: | bzr merge lp:~nik90/podbird/fix-textfield-color | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Sheldon | Approve | ||
Review via email: mp+257096@code.launchpad.net |
Description of the change
- Fixed placeholder text not being visible in the dark theme due to the backgroundText being set as White by the SDK.
- Fixed 2 strings that were not marked for translation in the episodes page
- Set version to v0.6
- Removed the name "Podbird" being marked for translation in the desktop file
It seems every other dark themed app does indeed use this hack,
// TODO: Workaround for pad.lv/1356779, force the theme's backgroundText color to work with the app's backgroundColor (music app)
Theme.palette.
To post a comment you must log in.
It turns out 2 strings "Mark episode as listened" and "Mark episode as unlistened" were not marked for translation in the episode page :/ .. Luckily the string "Mark episode as listened" was marked for translation in the what's new page. So that leaves one new string.
This is unfortunate as every other UI string in Podbird appears nicely translated except for that one string "Mark episode as unlistened".