Merge lp:~nik90/podbird/fix-textfield-color into lp:podbird

Proposed by Nekhelesh Ramananthan
Status: Merged
Merged at revision: 75
Proposed branch: lp:~nik90/podbird/fix-textfield-color
Merge into: lp:podbird
Diff against target: 121 lines (+19/-16)
5 files modified
app/Podbird.desktop.in (+1/-1)
app/podbird.qml (+3/-0)
app/settings/About.qml (+1/-1)
app/ui/EpisodesPage.qml (+1/-1)
po/com.mikeasoft.podbird.pot (+13/-13)
To merge this branch: bzr merge lp:~nik90/podbird/fix-textfield-color
Reviewer Review Type Date Requested Status
Michael Sheldon Approve
Review via email: mp+257096@code.launchpad.net

Description of the change

- Fixed placeholder text not being visible in the dark theme due to the backgroundText being set as White by the SDK.
- Fixed 2 strings that were not marked for translation in the episodes page
- Set version to v0.6
- Removed the name "Podbird" being marked for translation in the desktop file

It seems every other dark themed app does indeed use this hack,

// TODO: Workaround for pad.lv/1356779, force the theme's backgroundText color to work with the app's backgroundColor (music app)

Theme.palette.normal.backgroundText = "#81888888"

To post a comment you must log in.
75. By Nekhelesh Ramananthan

Fixed 2 strings that were not marked for translation in the episodes page :/

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

It turns out 2 strings "Mark episode as listened" and "Mark episode as unlistened" were not marked for translation in the episode page :/ .. Luckily the string "Mark episode as listened" was marked for translation in the what's new page. So that leaves one new string.

This is unfortunate as every other UI string in Podbird appears nicely translated except for that one string "Mark episode as unlistened".

76. By Nekhelesh Ramananthan

Set version to final v0.6

77. By Nekhelesh Ramananthan

Removed Podbird marked as translation in the desktop file

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/Podbird.desktop.in'
2--- app/Podbird.desktop.in 2015-01-04 10:20:41 +0000
3+++ app/Podbird.desktop.in 2015-04-23 10:02:07 +0000
4@@ -1,5 +1,5 @@
5 [Desktop Entry]
6-_Name=Podbird
7+Name=Podbird
8 Comment=Podcast manager
9 Exec=@EXEC@
10 Icon=@ICON@
11
12=== modified file 'app/podbird.qml'
13--- app/podbird.qml 2015-04-22 10:15:34 +0000
14+++ app/podbird.qml 2015-04-23 10:02:07 +0000
15@@ -93,6 +93,9 @@
16 Themes.ThemeManager {
17 id: themeManager
18 source: settings.themeName
19+ onSourceChanged: {
20+ Theme.palette.normal.backgroundText = UbuntuColors.lightGrey
21+ }
22 }
23
24 property alias appTheme: themeManager.theme
25
26=== modified file 'app/settings/About.qml'
27--- app/settings/About.qml 2015-04-22 10:15:34 +0000
28+++ app/settings/About.qml 2015-04-23 10:02:07 +0000
29@@ -49,7 +49,7 @@
30 Label {
31 width: parent.width
32 horizontalAlignment: Text.AlignHCenter
33- text: i18n.tr("Version %1").arg("0.6.beta3")
34+ text: i18n.tr("Version %1").arg("0.6")
35 }
36 }
37
38
39=== modified file 'app/ui/EpisodesPage.qml'
40--- app/ui/EpisodesPage.qml 2015-04-22 10:15:34 +0000
41+++ app/ui/EpisodesPage.qml 2015-04-23 10:02:07 +0000
42@@ -306,7 +306,7 @@
43 Label {
44 id: listenText
45 color: UbuntuColors.darkGrey
46- text: popover.listened ? "Mark episode unlistened" : "Mark episode listened"
47+ text: popover.listened ? i18n.tr("Mark episode unlistened") : i18n.tr("Mark episode listened")
48 }
49 }
50
51
52=== modified file 'po/com.mikeasoft.podbird.pot'
53--- po/com.mikeasoft.podbird.pot 2015-04-22 10:15:34 +0000
54+++ po/com.mikeasoft.podbird.pot 2015-04-23 10:02:07 +0000
55@@ -8,7 +8,7 @@
56 msgstr ""
57 "Project-Id-Version: \n"
58 "Report-Msgid-Bugs-To: \n"
59-"POT-Creation-Date: 2015-04-22 09:52+0000\n"
60+"POT-Creation-Date: 2015-04-23 09:57+0000\n"
61 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
62 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
63 "Language-Team: LANGUAGE <LL@li.org>\n"
64@@ -19,19 +19,19 @@
65 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
66
67 #. TRANSLATORS: this refers to a number of songs greater than one. The actual number will be prepended to the string automatically (plural forms are not yet fully supported in usermetrics, the library that displays that string)
68-#: ../app/podbird.qml:162
69+#: ../app/podbird.qml:165
70 msgid "podcasts listened to today"
71 msgstr ""
72
73-#: ../app/podbird.qml:163
74+#: ../app/podbird.qml:166
75 msgid "No podcasts listened to today"
76 msgstr ""
77
78-#: ../app/podbird.qml:225
79+#: ../app/podbird.qml:228
80 msgid "Add New Podcasts"
81 msgstr ""
82
83-#: ../app/podbird.qml:239
84+#: ../app/podbird.qml:242
85 msgid "Settings"
86 msgstr ""
87
88@@ -193,6 +193,14 @@
89 msgid "Download episode"
90 msgstr ""
91
92+#: ../app/ui/EpisodesPage.qml:309
93+msgid "Mark episode unlistened"
94+msgstr ""
95+
96+#: ../app/ui/EpisodesPage.qml:309 ../app/ui/WhatsNewTab.qml:262
97+msgid "Mark episode listened"
98+msgstr ""
99+
100 #: ../app/ui/EpisodesPage.qml:335
101 msgid "No more episodes"
102 msgstr ""
103@@ -395,10 +403,6 @@
104 msgid "No Episodes found matching the search term."
105 msgstr ""
106
107-#: ../app/ui/WhatsNewTab.qml:262
108-msgid "Mark episode listened"
109-msgstr ""
110-
111 #: ../app/ui/WhatsNewTab.qml:302
112 msgid "Pause Episode"
113 msgstr ""
114@@ -492,7 +496,3 @@
115 #: ../app/welcomewizard/Slide6.qml:76
116 msgid "Finish"
117 msgstr ""
118-
119-#: /home/krnekhelesh/Documents/Ubuntu-Projects/MP-Reviews/builddir/build-fix-vivid-crash-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/Podbird.desktop.in.h:1
120-msgid "Podbird"
121-msgstr ""

Subscribers

People subscribed via source and target branches