Merge lp:~nik90/podbird/episode-page-tweak into lp:podbird

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Michael Sheldon
Approved revision: 28
Merged at revision: 28
Proposed branch: lp:~nik90/podbird/episode-page-tweak
Merge into: lp:podbird
Diff against target: 74 lines (+11/-9)
2 files modified
app/ui/EpisodesPage.qml (+6/-4)
po/com.mikeasoft.podbird.pot (+5/-5)
To merge this branch: bzr merge lp:~nik90/podbird/episode-page-tweak
Reviewer Review Type Date Requested Status
Michael Sheldon Approve
Review via email: mp+251373@code.launchpad.net

Commit message

Replaced artist with published date in the episodes page and allowed the episode title to use 2 lines to reduce truncation.

Description of the change

This small MP does the following,
- Replace artist with published date in the episodes page as it is more important considering that the artist of episodes from the same podcast are going to be the same anyway.

- Allowed the episode title to use 2 lines since truncated titles make it quite hard to understand what the episode is about.

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/EpisodesPage.qml'
2--- app/ui/EpisodesPage.qml 2015-01-31 16:09:23 +0000
3+++ app/ui/EpisodesPage.qml 2015-02-28 19:44:27 +0000
4@@ -241,14 +241,16 @@
5 textFormat: Text.PlainText
6 text: model.name.trim()
7 width: parent.width
8+ maximumLineCount: 2
9+ wrapMode: Text.WordWrap
10 elide: Text.ElideRight
11 }
12
13 Label {
14- id: episodeArtist
15+ id: episodePublishDate
16 width: parent.width
17- text: model.artist
18- fontSize: "small"
19+ text: Qt.formatDate(new Date(model.published), "MMM d, yyyy")
20+ fontSize: "x-small"
21 elide: Text.ElideRight
22 }
23 }
24@@ -460,7 +462,7 @@
25 episodeModel.pid = pid;
26 episodeModel.artist = artist;
27 episodeModel.image = img;
28- episodeModel.append({"guid" : episode.guid, "listened" : episode.listened, "name" : episode.name, "description" : episode.description, "duration" : episode.duration, "position" : episode.position, "downloadedfile" : episode.downloadedfile, "image" : img, "artist" : artist, "audiourl" : episode.audiourl});
29+ episodeModel.append({"guid" : episode.guid, "listened" : episode.listened, "published": episode.published, "name" : episode.name, "description" : episode.description, "duration" : episode.duration, "position" : episode.position, "downloadedfile" : episode.downloadedfile, "image" : img, "artist" : artist, "audiourl" : episode.audiourl});
30 }
31 });
32 }
33
34=== modified file 'po/com.mikeasoft.podbird.pot'
35--- po/com.mikeasoft.podbird.pot 2015-01-31 16:09:23 +0000
36+++ po/com.mikeasoft.podbird.pot 2015-02-28 19:44:27 +0000
37@@ -8,7 +8,7 @@
38 msgstr ""
39 "Project-Id-Version: \n"
40 "Report-Msgid-Bugs-To: \n"
41-"POT-Creation-Date: 2015-01-31 16:08+0000\n"
42+"POT-Creation-Date: 2015-02-28 20:40+0100\n"
43 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
44 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
45 "Language-Team: LANGUAGE <LL@li.org>\n"
46@@ -64,17 +64,17 @@
47 msgid "No episodes found matching the search term."
48 msgstr ""
49
50-#: ../app/ui/EpisodesPage.qml:287
51+#: ../app/ui/EpisodesPage.qml:289
52 #, qt-format
53 msgid "%1h %2m"
54 msgstr ""
55
56-#: ../app/ui/EpisodesPage.qml:293
57+#: ../app/ui/EpisodesPage.qml:295
58 #, qt-format
59 msgid "%1h"
60 msgstr ""
61
62-#: ../app/ui/EpisodesPage.qml:298
63+#: ../app/ui/EpisodesPage.qml:300
64 #, c-format, qt-format
65 msgid "%1m"
66 msgstr ""
67@@ -152,6 +152,6 @@
68 msgid "Subscribe"
69 msgstr ""
70
71-#: /home/mike/src/build-podbird-Ubuntu_Device3_GCC_armhf_ubuntu_sdk_14_10_utopic-Default/po/Podbird.desktop.in.h:1
72+#: /home/krnekhelesh/Documents/Ubuntu-Projects/MP-Reviews/builddir/build-show-publish-date-UbuntuSDK_for_i386_GCC_ubuntu_sdk_14_10_utopic-Default/po/Podbird.desktop.in.h:1
73 msgid "Podbird"
74 msgstr ""

Subscribers

People subscribed via source and target branches