Merge lp:~nik90/podbird/5-auto-download-option into lp:podbird
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 43 | ||||
| Proposed branch: | lp:~nik90/podbird/5-auto-download-option | ||||
| Merge into: | lp:podbird | ||||
| Prerequisite: | lp:~nik90/podbird/4-add-welcome-wizard | ||||
| Diff against target: |
767 lines (+400/-231) 10 files modified
Podbird.apparmor (+3/-2) app/CMakeLists.txt (+1/-0) app/podbird.qml (+40/-3) app/settings/CMakeLists.txt (+7/-0) app/settings/CleanSetting.qml (+65/-0) app/settings/DownloadSetting.qml (+64/-0) app/settings/ThemeSetting.qml (+63/-0) app/ui/ExpandableListItem.qml (+0/-87) app/ui/SettingsPage.qml (+72/-90) po/com.mikeasoft.podbird.pot (+85/-49) |
||||
| To merge this branch: | bzr merge lp:~nik90/podbird/5-auto-download-option | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Sheldon | 2015-03-30 | Approve on 2015-04-16 | |
|
Review via email:
|
|||
Description of the Change
This branch adds the most requested feature which is auto-download new episodes on app startup. By default this is disabled, but can be easily enabled from the settings page. It also now provides a settings option to only download when on wifi.
Please test this on your BQ device with 3G only and wifi only to see if the settings options are obeyed.
I also cleaned up the settings page which now looks way better in my opinion.
- 49. By Nekhelesh Ramananthan on 2015-03-30
-
First sort episode list by desc published date before proceeding to download the most recent one
- 50. By Nekhelesh Ramananthan on 2015-03-31
-
Removed left-over code in settings.qml and also changed days to months/year appropriately
- 51. By Nekhelesh Ramananthan on 2015-04-01
-
Merged prerequisite lp:~nik90/podbird/4-add-welcome-wizard
- 52. By Nekhelesh Ramananthan on 2015-04-01
-
Added more log statements to allow for easier debugging
- 53. By Nekhelesh Ramananthan on 2015-04-06
-
Dynamically load/unload the settings page to optimize app startup time
- 54. By Nekhelesh Ramananthan on 2015-04-07
-
Disable autodownload on wifi option until user enabled autodownload itself
- 55. By Nekhelesh Ramananthan on 2015-04-11
-
merged prerequisite
- 56. By Nekhelesh Ramananthan on 2015-04-11
-
Removed dividers from the settings listitems
- 57. By Nekhelesh Ramananthan on 2015-04-15
-
merged prerequisite fix
- 58. By Nekhelesh Ramananthan on 2015-04-15
-
merged trunk
- 59. By Nekhelesh Ramananthan on 2015-04-15
-
merged lp:podbird
- 60. By Nekhelesh Ramananthan on 2015-04-15
-
Removed expandable list item component since we dont use it anymore in Podbird
| Michael Sheldon (michael-sheldon) wrote : | # |
Looks like there's already a bug open for this here: https:/
| Michael Sheldon (michael-sheldon) wrote : | # |
I think we should probably just hide the "Wifi only" option until this is fixed in the connectivity API, at least that way we aren't promising the user something we can't offer.
| Michael Sheldon (michael-sheldon) wrote : | # |
Added missing inline comment
- 61. By Nekhelesh Ramananthan on 2015-04-15
-
Removed the limited bandwidth detection as it is not working on krillin. Also fixed log statement
- 62. By Nekhelesh Ramananthan on 2015-04-16
-
Fixed a string not being internationalized
- 63. By Nekhelesh Ramananthan on 2015-04-16
-
merged lp:podbird


NetworkingStatu s.limitedBandwi th is always returning false for me regardless of whether I'm on wifi or 3G, looks like this might need a work around until that's fixed. I'll try to investigate this a bit more tomorrow, file a bug against the connectivity api and see what we can do about it.
There's also one inline comment about a slightly ambiguous log message.
Other than those issues this is looking good.