Merge lp:~nik90/podbird/13-statesaver into lp:podbird

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Michael Sheldon
Approved revision: 84
Merged at revision: 89
Proposed branch: lp:~nik90/podbird/13-statesaver
Merge into: lp:podbird
Prerequisite: lp:~nik90/podbird/12-optimize-playbar
Diff against target: 49 lines (+8/-4)
2 files modified
app/podbird.qml (+4/-0)
po/com.mikeasoft.podbird.pot (+4/-4)
To merge this branch: bzr merge lp:~nik90/podbird/13-statesaver
Reviewer Review Type Date Requested Status
Michael Sheldon Approve
Review via email: mp+257453@code.launchpad.net

Description of the change

This MP adds statesaver which will now remember the last used tab by the user and restore that correctly when the app is killed by the system and brought back when the user navigates back to Podbird.

Steps to test:
1. Install this MP and then open Podbird and switch to the settings tab.
2. Open a lot of webapps..until the system is heavily loaded
3. Let's try switching apps now...if the podbird app screenshot is blurry, the system killed it. Now switch to podbird. The last used tab should be shown correctly.

To post a comment you must log in.
lp:~nik90/podbird/13-statesaver updated
83. By Nekhelesh Ramananthan

merged prerequisite lp:~nik90/podbird/12-optimize-playbar

84. By Nekhelesh Ramananthan

merged prerequisite lp:~nik90/podbird/12-optimize-playbar

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Works nicely

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/podbird.qml'
2--- app/podbird.qml 2015-06-13 16:55:01 +0000
3+++ app/podbird.qml 2015-06-13 16:55:01 +0000
4@@ -219,6 +219,10 @@
5 Tabs {
6 id: tabs
7
8+ // Ensure that the last used tab is restored when the app gets killed
9+ // and brought by the system.
10+ StateSaver.properties: "selectedTabIndex"
11+
12 WhatsNewTab {
13 id: whatsNewTab
14 objectName: "whatsNewTab"
15
16=== modified file 'po/com.mikeasoft.podbird.pot'
17--- po/com.mikeasoft.podbird.pot 2015-06-13 16:55:01 +0000
18+++ po/com.mikeasoft.podbird.pot 2015-06-13 16:55:01 +0000
19@@ -8,7 +8,7 @@
20 msgstr ""
21 "Project-Id-Version: \n"
22 "Report-Msgid-Bugs-To: \n"
23-"POT-Creation-Date: 2015-04-28 23:23+0000\n"
24+"POT-Creation-Date: 2015-04-28 23:26+0000\n"
25 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
26 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
27 "Language-Team: LANGUAGE <LL@li.org>\n"
28@@ -32,11 +32,11 @@
29 msgid "No podcasts listened to today"
30 msgstr ""
31
32-#: ../app/podbird.qml:229
33+#: ../app/podbird.qml:233
34 msgid "Add New Podcasts"
35 msgstr ""
36
37-#: ../app/podbird.qml:243
38+#: ../app/podbird.qml:247
39 msgid "Settings"
40 msgstr ""
41
42@@ -512,6 +512,6 @@
43 msgid "Finish"
44 msgstr ""
45
46-#: /home/krnekhelesh/Documents/Ubuntu-Projects/MP-Reviews/builddir/build-12-optimize-playbar-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/Podbird.desktop.in.h:1
47+#: /home/krnekhelesh/Documents/Ubuntu-Projects/MP-Reviews/builddir/build-13-statesaver-UbuntuSDK_for_armhf_GCC_ubuntu_sdk_15_04_vivid-Default/po/Podbird.desktop.in.h:1
48 msgid "The chirpiest podcast manager for Ubuntu"
49 msgstr ""

Subscribers

People subscribed via source and target branches