Merge lp:~nik90/owncloud-sync/aboutpage into lp:owncloud-sync

Proposed by Nekhelesh Ramananthan
Status: Merged
Merged at revision: 4
Proposed branch: lp:~nik90/owncloud-sync/aboutpage
Merge into: lp:owncloud-sync
Diff against target: 166 lines (+111/-8)
3 files modified
Owncloud-Sync/Owncloud-Sync/Main.qml (+16/-6)
Owncloud-Sync/Owncloud-Sync/ui/AboutPage.qml (+93/-0)
Owncloud-Sync/Owncloud-Sync/ui/AccountSettingsPage.qml (+2/-2)
To merge this branch: bzr merge lp:~nik90/owncloud-sync/aboutpage
Reviewer Review Type Date Requested Status
Dubstar_04 Pending
Review via email: mp+293740@code.launchpad.net

Description of the change

Added a basic about page showing the version and other details of owncloud-sync.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Owncloud-Sync/Owncloud-Sync/Main.qml'
2--- Owncloud-Sync/Owncloud-Sync/Main.qml 2016-04-22 20:48:15 +0000
3+++ Owncloud-Sync/Owncloud-Sync/Main.qml 2016-05-04 09:53:14 +0000
4@@ -152,6 +152,7 @@
5 property string serverURL
6 property string lastSync
7 property bool mobileData
8+ property string owncloudcmdVersion
9 }
10
11 layouts: PageColumnsLayout {
12@@ -176,11 +177,20 @@
13 AccountSettingsPage {
14 id: ocSettings
15
16- trailingAction: Action {
17- iconName: "document-open"
18- visible: apl.windowWidth < apl.maxWidth
19- text: i18n.tr("Folders")
20- onTriggered: apl.addPageToNextColumn(apl.primaryPageSource, syncSettings)
21+ trailingAction: ActionList {
22+ children: [
23+ Action {
24+ iconName: "document-open"
25+ visible: apl.windowWidth < apl.maxWidth
26+ text: i18n.tr("Folders")
27+ onTriggered: apl.addPageToNextColumn(apl.primaryPageSource, syncSettings)
28+ },
29+
30+ Action {
31+ iconName: "info"
32+ onTriggered: apl.addPageToCurrentColumn(apl.primaryPageSource, Qt.resolvedUrl("ui/AboutPage.qml"), {daemonVersion: accountSettings.owncloudcmdVersion})
33+ }
34+ ]
35 }
36
37 accountSettings: {
38@@ -194,7 +204,7 @@
39
40
41 onConnectClicked: {
42- testConnection(username, password, timer, serverURL, mobileData, lastSync)
43+ testConnection(username, password, timer, serverURL, mobileData, lastSync)
44 }
45 }
46
47
48=== added file 'Owncloud-Sync/Owncloud-Sync/ui/AboutPage.qml'
49--- Owncloud-Sync/Owncloud-Sync/ui/AboutPage.qml 1970-01-01 00:00:00 +0000
50+++ Owncloud-Sync/Owncloud-Sync/ui/AboutPage.qml 2016-05-04 09:53:14 +0000
51@@ -0,0 +1,93 @@
52+import QtQuick 2.4
53+import Ubuntu.Components 1.3
54+
55+Page {
56+ id: aboutPage
57+
58+ property string daemonVersion: ""
59+
60+ header: PageHeader {
61+ title: i18n.tr("About")
62+ flickable: flickable
63+ }
64+
65+ Flickable {
66+ id: flickable
67+
68+ anchors.fill: parent
69+ contentHeight: dataColumn.height + units.gu(10) + dataColumn.anchors.topMargin
70+
71+ Column {
72+ id: dataColumn
73+
74+ spacing: units.gu(3)
75+ anchors {
76+ top: parent.top; left: parent.left; right: parent.right; topMargin: units.gu(5)
77+ }
78+
79+ Image {
80+ height: width
81+ width: Math.min(parent.width/2, parent.height/2)
82+ source: "../Owncloud-Sync.png"
83+ anchors.horizontalCenter: parent.horizontalCenter
84+ }
85+
86+ Label {
87+ width: parent.width
88+ textSize: Label.XLarge
89+ font.weight: Font.DemiBold
90+ horizontalAlignment: Text.AlignHCenter
91+ text: "Owncloud Sync"
92+ }
93+
94+ Column {
95+ width: parent.width
96+
97+ Label {
98+ width: parent.width
99+ horizontalAlignment: Text.AlignHCenter
100+ // TRANSLATORS: Owncloud Sync version number e.g Version 0.1
101+ text: i18n.tr("Client Version %1").arg("0.1")
102+ }
103+
104+ Label {
105+ width: parent.width
106+ horizontalAlignment: Text.AlignHCenter
107+ // TRANSLATORS: Owncloud Sync daemon version number e.g Version 1.8.1
108+ text: i18n.tr("Daemon Version %1").arg(daemonVersion)
109+ }
110+ }
111+
112+ Column {
113+ anchors {
114+ left: parent.left
115+ right: parent.right
116+ margins: units.gu(2)
117+ }
118+ Label {
119+ width: parent.width
120+ wrapMode: Text.WordWrap
121+ horizontalAlignment: Text.AlignHCenter
122+ text: "(C) 2016 Owncloud Sync Devs"
123+ }
124+ Label {
125+ textSize: Label.Small
126+ width: parent.width
127+ wrapMode: Text.WordWrap
128+ horizontalAlignment: Text.AlignHCenter
129+ text: i18n.tr("Released under the terms of the GNU GPL v3")
130+ }
131+ }
132+
133+ Label {
134+ width: parent.width
135+ wrapMode: Text.WordWrap
136+ textSize: Label.Small
137+ horizontalAlignment: Text.AlignHCenter
138+ text: i18n.tr("Source code available on %1").arg("<a href=\"https://launchpad.net/owncloud-sync\">launchpad.net</a>")
139+ onLinkActivated: Qt.openUrlExternally(link)
140+ }
141+ }
142+ }
143+}
144+
145
146=== modified file 'Owncloud-Sync/Owncloud-Sync/ui/AccountSettingsPage.qml'
147--- Owncloud-Sync/Owncloud-Sync/ui/AccountSettingsPage.qml 2016-04-23 10:26:58 +0000
148+++ Owncloud-Sync/Owncloud-Sync/ui/AccountSettingsPage.qml 2016-05-04 09:53:14 +0000
149@@ -6,7 +6,7 @@
150 id: accountSettingsPage
151
152 // Page header trailing action
153- property Action trailingAction
154+ property ActionList trailingAction
155
156 // Signal fired when connect button is clicked
157 signal connectClicked(string username, string password, int timer, string serverURL, bool mobileData, string lastSync)
158@@ -17,7 +17,7 @@
159 id: header
160 title: i18n.tr("Owncloud Settings")
161 flickable: accountSettingsFlickable
162- trailingActionBar.actions: accountSettingsPage.trailingAction
163+ trailingActionBar.actions: accountSettingsPage.trailingAction.actions
164 }
165
166 Flickable {

Subscribers

People subscribed via source and target branches