Merge lp:~nik-jov-92/ubuntu-calculator-app/multiple_equals into lp:~acerisara/ubuntu-calculator-app/operation-after-clear
Status: | Needs review |
---|---|
Proposed branch: | lp:~nik-jov-92/ubuntu-calculator-app/multiple_equals |
Merge into: | lp:~acerisara/ubuntu-calculator-app/operation-after-clear |
Diff against target: |
68 lines (+40/-2) 2 files modified
app/tests/autopilot/ubuntu_calculator_app/__init__.py (+25/-2) app/tests/autopilot/ubuntu_calculator_app/tests/test_main.py (+15/-0) |
To merge this branch: | bzr merge lp:~nik-jov-92/ubuntu-calculator-app/multiple_equals |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bartosz Kosiorek (community) | Disapprove on 2015-07-09 | ||
Nicholas Skaggs | 2015-01-08 | Pending | |
Andrea Cerisara | 2015-01-08 | Pending | |
Review via email:
|
Description of the change
Implemented test for bug #1400890. Test named "test_multiple_
Andrea Cerisara (acerisara) wrote : | # |
In addition to what Bartosz said (even though in this case I would prefer to check explicitly for the size), please merge trunk and use _assert_result_is / _assert_
Nikola Jovanovic (nik-jov-92) wrote : | # |
Mr. Andrea,
I'm sorry for late responding. I will get right on it, just one little question is there a way to set a breakpoint like in Visual Studio so I can review it by lines of code and is there a way to print something in the terminal as autopilot goes? Thank you for your time and review I will get right on it :-)
Best Regards,
Nikola Jovanovic
<email address hidden>
> To: <email address hidden>
> From: <email address hidden>
> Subject: Re: [Merge] lp:~nik-jov-92/ubuntu-calculator-app/multiple_equals into lp:~acerisara/ubuntu-calculator-app/operation-after-clear
> Date: Fri, 9 Jan 2015 21:40:11 +0000
>
> In addition to what Bartosz said (even though in this case I would prefer to check explicitly for the size), please merge trunk and use _assert_result_is / _assert_
> --
> https:/
> You are the owner of lp:~nik-jov-92/ubuntu-calculator-app/multiple_equals.
Andrea Cerisara (acerisara) wrote : | # |
Ciao Nikola,
to print something in the terminal, print(obj). To debug you can use pdb, take a look at https:/
Niklas Wenzel (nikwen) wrote : | # |
The bug has been fixed now, so I think we can close this MP.
Unmerged revisions
- 49. By Nikola Jovanovic on 2015-01-08
-
fix testcase for multiple equals
Thanks Nikola. Great job!
First please take a look at our README file (into "Clean/Beautiful Code" section).
It will be great if you will follow these rules.
Please take a look at my inline comments.
Please also modify this Merge Request, to merge into: /code.launchpad .net/~ubuntu- calculator- dev/ubuntu- calculator- app/reboot
lp:ubuntu-calculator-app/reboot
https:/