Merge lp:~nijaba/vmbuilder/rawsize-lp303882 into lp:vmbuilder/trunk

Proposed by Nick Barcet
Status: Needs review
Proposed branch: lp:~nijaba/vmbuilder/rawsize-lp303882
Merge into: lp:vmbuilder/trunk
To merge this branch: bzr merge lp:~nijaba/vmbuilder/rawsize-lp303882
Reviewer Review Type Date Requested Status
Soren Hansen Needs Fixing
Review via email:
To post a comment you must log in.
Revision history for this message
Soren Hansen (soren) wrote :


this will fail if only one --raw argument is passed, but VM expects more than one size (if there's multiple disks), since you unconditionally do a vm.raw[diskid]. Either rework the patch to only use the value if it is actually given, or make it check if the right number of arguments are given.

review: Needs Fixing

Unmerged revisions

279. By Nick Barcet

  * raw can now be specified multiple times
  * preallocated image size is not assumed to 5G anymore (LP: #303882)


People subscribed via source and target branches