Merge lp:~nijaba/byobu/configure-keybindings into lp:byobu

[Nick Barcet]

[lp:~nijaba/byobu/configure-keybindings]

61. By Nick Barcet on 2009-01-19

esc key should only be one key

62. By Nick Barcet on 2009-01-19

better logic for esc key

[Dustin Kirkland  (kirkland)]

On Sat, Jan 17, 2009 at 5:31 AM, Nick Barcet <email address hidden> wrote:
> Nick Barcet has proposed merging lp:~nijaba/screen-profiles/configure-keybindings into lp:screen-profiles.
>
> Requested reviews:
> Dustin Kirkland (kirkland)

Nick-

I've been working on this merge for quite a while now...

There are a couple of conflicts with the current tree, which need to
be resolved.

I'm on the fence about the dynamic help generation. I'm concerned
that it's over-engineering the problem. I'm still processing all of
what's happening in the code.

I don't think the capitalized "Default" file looks very good in our
tree--we're not using caps anywhere else.

And I think there's a mistake in the select-screen-profile code, which
appears to copy the windows/Default file instead of the
keybindings/Default file.

I'm still working my way through the extensive changes to
screen-profiles-helper. There seems to be quite a bit of undocumented
changes to the default windows handling code.

It would *really* help if each of your functional changes was a
subsequent commit against your branch. Then, I could read the patches
between each revision.

Of all the code in here, I think the most important is the bit that
would allow you to tweak your ctrl key. I think that one thing would
be a very nice, atomic addition, and deserves a commit of its own.

Dynamic help file generation is something separate. This would be a
separate commit.

As is the Shift-Tab keybinding profile (I like what you're going for
here, we just need to figure out the best way to describe it). Again,
commit this separately.

And the windows changes is totally separate too. Ditto, separate commit.

:-Dustin

[Dustin Kirkland  (kirkland)]

Doing some cleanup, and I think this merge proposal is really old, and superceded by the modern code.

review: Disapprove

Unmerged revisions

62. By Nick Barcet on 2009-01-19

better logic for esc key

61. By Nick Barcet on 2009-01-19

esc key should only be one key

60. By Nick Barcet on 2009-01-17

allow to set escape key and select a keybinding profile (LP: #317675)