Merge lp:~nigelbabu/summit/782062-fix-naming into lp:summit

Proposed by Nigel Babu
Status: Merged
Approved by: Michael Hall
Approved revision: 117
Merged at revision: 122
Proposed branch: lp:~nigelbabu/summit/782062-fix-naming
Merge into: lp:summit
Diff against target: 11 lines (+1/-0)
1 file modified
summit/schedule/models/summitmodel.py (+1/-0)
To merge this branch: bzr merge lp:~nigelbabu/summit/782062-fix-naming
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Summit Hackers Pending
Review via email: mp+62044@code.launchpad.net

Commit message

Remove the '.' from the name of the meeting and replace it with '-'

Description of the change

Removes the '.' from the name of the meeting and replaces it with '-'

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Looks good.

Thanks,

James

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

We need to replace any weird chars. There was a session in UDS-M that used two "+" characters.. I think we may need a better solution for this.

Revision history for this message
Nigel Babu (nigelbabu) wrote :

My only concern is to make this field url safe. Is it better to just use urlencode instead?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/summitmodel.py'
2--- summit/schedule/models/summitmodel.py 2011-04-29 16:04:00 +0000
3+++ summit/schedule/models/summitmodel.py 2011-05-23 22:08:27 +0000
4@@ -207,6 +207,7 @@
5 name = elem.get("name", "")
6 if not name:
7 return
8+ name = name.replace('.','-')
9
10 print "meeting %s" % name
11 meeting = ""

Subscribers

People subscribed via source and target branches