Merge lp:~nigelbabu/launchpad/ubuntu-font-787798 into lp:launchpad

[Nigel Babu]

[r=bac][ui=sinzui][bug=787798] Use Google Web Fonts so Launchpad always displays in Ubuntu font

= Description =
Use Google Web Fonts so Launchpad always displays in Ubuntu font

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/templates/base-layout.pt

[Brad Crittenden (bac)]

Hi Nigel,

Thanks a ton for taking on this fix. It'll be huge when it lands.

A couple of thoughts:

Since Launchpad serves up everything over HTTPS having a reference to an external HTTP resource causes security warnings to pop up on some browsers. Luckily the same resource can be found via HTTPS.

Secondly, I'm not sure the change to the page template is the right place to make it. I've noticed some text is not using the font (e.g. the "Search Launchpad" button on the home page) so there may be CSS fixes that need to be made.

Let's get Curtis' opinion on this fix before you proceed. I'll request a review from him.

review: Needs Fixing (code)

[Curtis Hovey (sinzui)]

I think this line belongs in the launchpad-stylesheet-3-0 section of base-layout-macros.pt. I expect it is required before the line that loads the combo font.

review: Approve (ui)

[Brad Crittenden (bac)]

review: Approve (code)

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2011-09-02 10:54:46 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2011-09-06 15:33:18 +0000
@@ -166,7 +166,13 @@
     We can revisit this IE-only optimization if we remove SSL.  Any changes that
     affect IE should be tested using webpagetest.org. (See the dev.launchpad.net
     wiki for details.)
-  </tal:comment>
+    </tal:comment>
+  <link
+        type="text/css"
+        rel="stylesheet"
+        media="screen, print"
+        href="https://fonts.googleapis.com/css?family=Ubuntu" />
+
   <link
         type="text/css"
         rel="stylesheet"