Merge lp:~nigelbabu/launchpad/logo-links-713873 into lp:launchpad

[Nigel Babu]

Add a method to person to print the logo and mugshot urls directly

[Raphaël Badin (rvb)]

Hi Nigel, sorry for the late review. Like you said on IRC, you need to test the new methods (see the existing API tests for person in ./lib/lp/registry/browser/tests/test_person_webservice.py). In the current state, I'm afraid the LibraryFileAlias object returned by self.mugshot won't be converted into json and the call to person.getMugshotUrl() will fail.

BTW, to test this manually:
- setup a local instance
- log in and change the mugshot for the test user
- use the api to call the new method: http://paste.ubuntu.com/806227/

I'm marking this as needs fixing.

review: Needs Fixing

[Curtis Hovey (sinzui)]

I am rejecting this branch because a lot more work is needed to address this bug. As can be seeing lib/lp/app/browser/tales.py, getting the URL for a logo or mugshot is not simple. The proposed interface changes are fine. The implementation would need to move the URL logic from tales.py into the model. And any changes will need to be tested.

review: Disapprove

Unmerged revisions

14677. By Nigel Babu on 2012-01-14

Return the url of mugshot and logo directly

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2011-12-30 06:14:56 +0000
+++ lib/lp/registry/interfaces/person.py	2012-01-16 01:28:24 +0000
@@ -757,6 +757,22 @@
         :return: a PPA `IArchive` record corresponding to the name.
         """
 
+    @export_read_operation()
+    @operation_for_version("beta")
+    def getLogoUrl():
+        """Return link to logo.
+        
+        :return: The link to logo.
+        """
+
+    @export_read_operation()
+    @operation_for_version("beta")
+    def getMugshotUrl():
+        """Return link to mugshot.
+        
+        :return: The link to mugshot.
+        """
+
 
 class IPersonViewRestricted(IHasBranches, IHasSpecifications,
                     IHasMergeProposals, IHasMugshot,

=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py	2012-01-12 08:13:59 +0000
+++ lib/lp/registry/model/person.py	2012-01-16 01:28:24 +0000
@@ -3055,6 +3055,14 @@
     def canCreatePPA(self):
         """See `IPerson.`"""
         return self.subscriptionpolicy in CLOSED_TEAM_POLICY
+    
+    def getLogoUrl(self):
+        """See `IPerson.`"""
+        return self.logo
+
+    def getMugshotUrl(self):
+        """See `IPerson.`"""
+        return self.mugshot
 
 
 class PersonSet: